fix: correct loop bounds and rn[] indexing in numerical_jacobian.H#3
Merged
James471 merged 1 commit intoJun 2, 2026
Conversation
The radiation loop had two bugs: the upper bound `NumRadEqs` should be `net_ienuc + NumRadEqs` (the loop never executed since net_ienuc+1 > NumRadEqs), and `state.rn[i-1]` / `state.rn[j-1]` should be indexed relative to net_ienuc to correctly map VODE 1-based indices to the rn[] array. The inner loop upper bound was also off by one (`<= i + N` → `<= i + N - 1`). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
The numerical Jacobian implementation is incomplete, the radiation derivatives are never calculated. We also don't use it in any of our tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The radiation loop had two bugs: the upper bound
NumRadEqsshould benet_ienuc + NumRadEqs(the loop never executed since net_ienuc+1 > NumRadEqs), andstate.rn[i-1]/state.rn[j-1]should be indexed relative to net_ienuc to correctly map VODE 1-based indices to the rn[] array. The inner loop upper bound was also off by one (<= i + N→<= i + N - 1).