v1.0.0 implementation: panel persistence, smart-purge, CI fix#3
Merged
Conversation
CI was failing with "test source file ... was not found". Root cause: the solution maps the test project's Debug|x64 to Debug|Any CPU.ActiveCfg without a Build.0 entry, so msbuild /p:Platform=x64 doesn't actually build the test project. The MSBuild step then completes successfully, and the following 'dotnet test --no-build' step finds nothing to run. Adding Build.0 lines isn't a good fix because standalone MSBuild can't resolve Microsoft.NET.Sdk for the SDK-style test csproj without the .NET SDK on PATH. The CI runner happens to have it via setup-msbuild, but that creates a local-vs-CI divergence. Cleanest fix: drop --no-build from the dotnet test step. dotnet test invokes the SDK to build the test project (and transitively the plugin project via ProjectReference) before running tests. This mirrors the local workflow exactly. The preceding msbuild step still validates that the plugin builds for Debug|x64 specifically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-buildfrom the test step so dotnet builds the SDK-style test project; the prior msbuild /p:Platform=x64 step doesn't build it because the solution lacks a Build.0 entry for the test project at that platform.Test plan