Pass settings to MapperDelaunay in factory#207
Merged
Jammy2211 merged 2 commits intofeature/linalg_mixed_precisionfrom Feb 8, 2026
Merged
Pass settings to MapperDelaunay in factory#207Jammy2211 merged 2 commits intofeature/linalg_mixed_precisionfrom
Jammy2211 merged 2 commits intofeature/linalg_mixed_precisionfrom
Conversation
Co-authored-by: Jammy2211 <23455639+Jammy2211@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update linalg mixed precision implementation based on feedback
Pass settings to MapperDelaunay in factory
Feb 8, 2026
Jammy2211
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapper factory was not propagating
settingstoMapperDelaunay, causing caller-provided inversion settings (includinguse_mixed_precision) to be ignored for Delaunay meshes while working correctly for Rectangular and RectangularUniform meshes.Changes
settings=settingsparameter toMapperDelaunayconstructor call inmapper_from()factory functionAll three mapper types now consistently receive settings from the factory.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.