[tests] Add unit tests for ProbabilityFunctions (Erfinv, Erf, Erfc)#53
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
[tests] Add unit tests for ProbabilityFunctions (Erfinv, Erf, Erfc)#53github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Adds tests for the refactored ProbabilityFunctions.Erfinv that now uses the ErfInvSeriesCoefficients struct for lazy one-time coefficient initialization. Tests cover edge cases (out-of-range, boundary values), round-trip correctness (Erfinv(Erf(x)) ≈ x), odd-function symmetry, consistency of repeated calls, and Erf/Erfc complementary sum. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Try some comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for the changes introduced in PR #51.
What's covered
New test file:
test/Microsoft.ML.CpuMath.UnitTests/ProbabilityFunctionsTests.csTests for
ProbabilityFunctions(Erfinv,Erf,Erfc):ErfinvOutOfRangeAboveOneReturnsNaNErfinvOutOfRangeBelowNegativeOneReturnsNaNErfinvAtOneReturnsPositiveInfinityErfinvAtNegativeOneReturnsNegativeInfinityErfinvAtZeroReturnsZeroErfinvIsInverseOfErfErfinv(Erf(x)) ≈ xfor several valuesErfinvIsOddFunctionErfinv(-x) == -Erfinv(x)ErfinvRepeatedCallsReturnConsistentResultsErfAtPositiveInfinityReturnsOneErfAtNegativeInfinityReturnsNegativeOneErfAtZeroReturnsZeroErfcAtPositiveInfinityReturnsZeroErfcAtNegativeInfinityReturnsTwoErfAndErfcSumToOneErf(x) + Erfc(x) == 1for several valuesNotes
ErfinvRepeatedCallsReturnConsistentResultstest verifies the key behavioural guarantee of the PR — that the refactored static coefficient caching doesn't introduce per-call divergence.Microsoft.ML.CpuMath.UnitTestsconventions: xUnit[Fact]/[Theory],BaseTestClassbase, MIT license header.