[tests] tests: ProbabilityFunctions unit tests for Erfinv/Erf/Erfc/Probit#54
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
Add 57 unit tests covering the ProbabilityFunctions class changed in PR #51. Tests cover: - Erfinv boundary/special values (NaN, ±∞, 0) - Erfinv consistency (coefficient caching returns same result) - Erf/Erfinv round-trip accuracy - Erf/Erfc special values and symmetry - Erf + Erfc = 1 complement property - Probit valid/invalid inputs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive unit tests for
ProbabilityFunctionsto cover the changes introduced in PR #51.Related PR
Covers changes from #51 — performance fix for
Erfinvvia lazy-allocatedErfInvSeriesCoefficientsstruct.Test file created
test/Microsoft.ML.CpuMath.UnitTests/ProbabilityFunctionsTests.cs(275 lines, 57 tests)What is tested
Erfinvboundary/special valuesNaNfor out-of-range,±∞for±1,0forx=0ErfinvconsistencyErf/Erfinvround-tripErf(Erfinv(x)) ≈ xfor 9 values in(-1, 1)Erfspecial values+∞ → 1,-∞ → -1Erfcspecial values+∞ → 0,-∞ → 2Erf + Erfc = 1Erfodd symmetryErf(-x) == -Erf(x)ErfcsymmetryErfc(-x) == 2 - Erfc(x)Probitvalid inputsProbitinvalid inputs[0,1]throwArgumentOutOfRangeExceptionErfinv(0.5) ≈ 0.4769,Probit(0.5) ≈ 0All 57 tests pass.