Skip to content

Conversation

@The-D-007
Copy link
Contributor

Prepare


Description

Target issue

#12235

closes #12235

Implementation Details

Updated broken links in Janssen's FIDO2 server to point to correct references.


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

…2235

Signed-off-by: The-D-007 <ishantbishnoi07@gmail.com>
@mo-auto
Copy link
Member

mo-auto commented Sep 30, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ossdhaval
Copy link
Contributor

Hi @The-D-007 ,

Thank you for your PR. This one and a few others targeting the broken link issues in the documentation.

All the broken link issues are essentially good first issues (marked them so now). These issues help new community members to contribute and understand the process.

Since you have fixed couple of these issues, it would be really encouraging to see if you can pick up other issues apart from good first issues from the jans repository. Documentation issues or may be development bug fixes

Looking forward for your next contribution. :-)

@The-D-007
Copy link
Contributor Author

Hi @ossdhaval, thank you for the kind words and encouragement. I truly appreciate your guidance and the confidence you’ve shown in me. I’ll definitely start exploring other issues beyond the good first ones, including documentation and development bug fixes, and I look forward to learning from your feedback along the way.

@ossdhaval ossdhaval requested a review from manojs1978 October 3, 2025 09:38
@ossdhaval ossdhaval merged commit ca1bece into JanssenProject:main Oct 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(docs): broken link in the Janssen's FIDO2 server

4 participants