Skip to content

Conversation

@iromli
Copy link
Contributor

@iromli iromli commented Dec 26, 2025

Prepare


Description

Target issue

closes #12904

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Summary by CodeRabbit

  • Chores
    • Updated source versions in Docker build configurations across multiple services to include the latest assets and dependencies.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2025

📝 Walkthrough

Walkthrough

This PR updates the JANS_SOURCE_VERSION environment variable across 13 Dockerfiles to a new commit hash (6bcc41a). The change synchronizes asset source versions for Docker image builds without altering build logic or control flow.

Changes

Cohort / File(s) Change Summary
JANS_SOURCE_VERSION updates
docker-jans-all-in-one/Dockerfile, docker-jans-auth-server/Dockerfile, docker-jans-casa/Dockerfile, docker-jans-cloudtools/Dockerfile, docker-jans-config-api/Dockerfile, docker-jans-configurator/Dockerfile, docker-jans-fido2/Dockerfile, docker-jans-link/Dockerfile, docker-jans-monolith/Dockerfile, docker-jans-persistence-loader/Dockerfile, docker-jans-saml/Dockerfile, docker-jans-scim/Dockerfile, jans-cedarling/flask-sidecar/Dockerfile
Environment variable JANS_SOURCE_VERSION updated to 6bcc41a (docker-jans-config-api updated from a different previous hash)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

Suggested reviewers

  • moabu
  • misba7

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: syncing templates to OCI images, which aligns with the changeset of updating JANS_SOURCE_VERSION across multiple Dockerfiles.
Description check ✅ Passed The PR description follows the template structure with sections for Prepare, Target issue (closes #12904), and Test/Document checklist. However, Implementation Details section is empty, and test/documentation checkboxes are unchecked despite confirmation that there is no documentation impact.
Linked Issues check ✅ Passed The PR directly addresses the linked issue #12904 by synchronizing templates to OCI images through JANS_SOURCE_VERSION updates across all Dockerfile components, meeting the stated objective.
Out of Scope Changes check ✅ Passed All changes are in-scope: the PR updates JANS_SOURCE_VERSION consistently across 13 Dockerfiles to sync templates to OCI images, with no unrelated modifications or side effects.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bcc41a and d1e1d63.

📒 Files selected for processing (13)
  • docker-jans-all-in-one/Dockerfile
  • docker-jans-auth-server/Dockerfile
  • docker-jans-casa/Dockerfile
  • docker-jans-cloudtools/Dockerfile
  • docker-jans-config-api/Dockerfile
  • docker-jans-configurator/Dockerfile
  • docker-jans-fido2/Dockerfile
  • docker-jans-link/Dockerfile
  • docker-jans-monolith/Dockerfile
  • docker-jans-persistence-loader/Dockerfile
  • docker-jans-saml/Dockerfile
  • docker-jans-scim/Dockerfile
  • jans-cedarling/flask-sidecar/Dockerfile
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-11-10T17:38:39.610Z
Learnt from: iromli
Repo: JanssenProject/jans PR: 12679
File: docker-jans-config-api/Dockerfile:120-120
Timestamp: 2025-11-10T17:38:39.610Z
Learning: In docker-jans-config-api/Dockerfile, the sed command that replaces 'your-openid-provider.server' with '%(hostname)s' in the adminui-policy-store.json file is intentional. The %(hostname)s variable uses Python string interpolation format and is consumed by scripts executed during container runtime.

Applied to files:

  • docker-jans-config-api/Dockerfile
  • jans-cedarling/flask-sidecar/Dockerfile
  • docker-jans-fido2/Dockerfile
  • docker-jans-auth-server/Dockerfile
  • docker-jans-persistence-loader/Dockerfile
  • docker-jans-saml/Dockerfile
📚 Learning: 2025-11-18T07:43:55.761Z
Learnt from: pujavs
Repo: JanssenProject/jans PR: 12704
File: jans-config-api/docs/jans-config-api-swagger.yaml:17540-17546
Timestamp: 2025-11-18T07:43:55.761Z
Learning: The file `jans-config-api/docs/jans-config-api-swagger.yaml` is auto-generated with dependent modules changes and metadata. The config API does not override it.

Applied to files:

  • docker-jans-config-api/Dockerfile
  • docker-jans-configurator/Dockerfile
📚 Learning: 2025-11-26T12:38:52.165Z
Learnt from: misba7
Repo: JanssenProject/jans PR: 12737
File: automation/mysql.yaml:22-59
Timestamp: 2025-11-26T12:38:52.165Z
Learning: In the Janssen project, Kubernetes manifests in the automation/ directory (such as mysql.yaml and pgsql.yaml) are for demo and testing purposes only. These manifests do not require production-level hardening (security contexts, resource limits, health checks, etc.) as they are intended for local development and demonstration scenarios, not production deployments.

Applied to files:

  • docker-jans-casa/Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: docker (persistence-loader)
  • GitHub Check: docker (scim)
  • GitHub Check: docker (cloudtools)
  • GitHub Check: docker (monolith)
  • GitHub Check: docker (config-api)
  • GitHub Check: docker (configurator)
  • GitHub Check: docker (auth-server)
  • GitHub Check: docker (fido2)
  • GitHub Check: python_tests (3.10)
  • GitHub Check: python_tests (3.11)
  • GitHub Check: wasm_tests
  • GitHub Check: rust_benchmarks
  • GitHub Check: golang_tests
  • GitHub Check: rust_tests
🔇 Additional comments (13)
docker-jans-all-in-one/Dockerfile (1)

62-62: LGTM! Template source version updated consistently.

The JANS_SOURCE_VERSION update is consistent with the broader PR changes synchronizing templates across all OCI images.

jans-cedarling/flask-sidecar/Dockerfile (1)

34-34: LGTM! Asset source version synchronized.

The update aligns with the PR's objective to sync templates across all container images.

docker-jans-monolith/Dockerfile (1)

44-44: LGTM! Source version updated consistently.

The JANS_SOURCE_VERSION change is uniform across all Dockerfiles in this PR.

docker-jans-persistence-loader/Dockerfile (1)

21-21: LGTM! Template version synchronized across images.

The update is consistent with the PR's template synchronization objective.

docker-jans-configurator/Dockerfile (1)

30-30: LGTM! Asset source revision updated.

The change aligns with the broader template synchronization effort across all container images.

docker-jans-cloudtools/Dockerfile (1)

47-47: LGTM! Source version synchronized.

The JANS_SOURCE_VERSION update is consistent with the PR's objective to sync templates to OCI images.

docker-jans-fido2/Dockerfile (1)

70-70: LGTM! Template source version updated consistently.

The update completes the synchronization of JANS_SOURCE_VERSION across all affected Dockerfiles in this PR.

docker-jans-casa/Dockerfile (1)

64-64: LGTM! All Dockerfiles consistently updated to the same commit hash.

The JANS_SOURCE_VERSION at line 64 is set to 6bcc41a0e7f2708e52fe2c950d357dc872b87498 and is used in the git checkout at line 76. This version is consistently applied across all 13 affected Dockerfiles in the repository, confirming alignment with the PR objectives.

docker-jans-config-api/Dockerfile (1)

77-77: LGTM! Consistent version update.

The version update is consistent with other Dockerfiles in this PR.

docker-jans-scim/Dockerfile (1)

65-65: LGTM! Consistent version update.

The version update is consistent with other Dockerfiles in this PR.

docker-jans-auth-server/Dockerfile (1)

106-106: LGTM! Consistent version update.

The version update is consistent with other Dockerfiles in this PR.

docker-jans-link/Dockerfile (1)

66-66: LGTM! Consistent version update.

The version update is consistent with other Dockerfiles in this PR.

docker-jans-saml/Dockerfile (1)

42-42: Commit hash verified and update is consistent.

The JANS_SOURCE_VERSION update to 6bcc41a0e7f2708e52fe2c950d357dc872b87498 is confirmed to exist in the janssenproject/jans repository. The change aligns with the PR objective and the commit format is valid.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto
Copy link
Member

mo-auto commented Dec 26, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@iromli iromli self-assigned this Dec 29, 2025
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli marked this pull request as ready for review December 29, 2025 18:46
@iromli iromli requested a review from moabu as a code owner December 29, 2025 18:46
@moabu moabu merged commit bba0e74 into main Dec 30, 2025
3 checks passed
@moabu moabu deleted the cn-sync-images branch December 30, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(cloud-native): sync templates to OCI images

4 participants