-
Notifications
You must be signed in to change notification settings - Fork 160
feat(cloud-native): add feature to update config-api scopes sync from template #12909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… template Signed-off-by: iromli <isman.firmansyah@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughPerforms an upsert of Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)docker-jans-config-api/scripts/bootstrap.py (1)
🪛 Ruff (0.14.10)docker-jans-config-api/scripts/bootstrap.py413-413: Logging statement uses f-string (G004) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
docker-jans-config-api/scripts/bootstrap.py
🧰 Additional context used
🪛 Ruff (0.14.10)
docker-jans-config-api/scripts/bootstrap.py
411-411: Logging statement uses f-string
(G004)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: docker (scim)
- GitHub Check: docker (monolith)
- GitHub Check: docker (auth-server)
- GitHub Check: docker (cloudtools)
- GitHub Check: docker (config-api)
- GitHub Check: docker (fido2)
- GitHub Check: docker (configurator)
- GitHub Check: docker (persistence-loader)
🔇 Additional comments (1)
docker-jans-config-api/scripts/bootstrap.py (1)
414-414: LGTM!Correctly removed "scopes.ldif" from the batch processing list since it's now handled separately with upsert logic above.
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Prepare
Description
Target issue
closes #12908
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.