Conversation
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates docs build workflow to pull template overrides from main and enable Scarf/REO flags for versioned docs; mkdocs.yml adds toggles for those trackers; docs template conditionalizes Scarf/REO inclusion; removes a subtitle from one docs page front matter. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build-docs.yml:
- Around line 159-163: Add a short diagnostic check immediately after the two
sed commands that toggles enable_scarf_pixel and enable_reo_flag in mkdocs.yml:
run a grep (or similar) for both keys in mkdocs.yml and echo the matching lines
(or a clear "not found" message) so the workflow logs whether the substitutions
occurred; reference the existing sed commands that modify mkdocs.yml and place
the verification before the subsequent mike deploy step, leaving the current
event condition unchanged (confirming that head pushes to main remain excluded
if intended).
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build-docs.yml:
- Around line 159-165: Update the step named "Enable Scarf and Reo tracking for
versioned docs" so its if-condition matches the deploy guards: keep allowing
manual runs (github.event_name == 'workflow_dispatch') but for release events
require github.event.action == 'published', !github.event.release.draft, and
that the release tag is versioned or nightly
(startsWith(github.event.release.tag_name, 'v') || github.event.release.tag_name
== 'nightly'); this prevents sed edits to mkdocs.yml (the two sed commands that
toggle enable_scarf_pixel and enable_reo_flag) from running for releases that
will not be deployed.
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build-docs.yml:
- Around line 159-163: The workflow step named "Use latest template overrides
from main" can fail because docs/overrides/ may not exist in older tags; modify
that step's run block to ensure the target directory exists before the git show
redirect by running mkdir -p docs/overrides/ (or equivalent) prior to executing
git show origin/main:docs/overrides/main.html > docs/overrides/main.html so the
redirection cannot fail due to a missing directory.
---
Duplicate comments:
In @.github/workflows/build-docs.yml:
- Around line 164-165: The "Enable Reo and Scarf tracking for versioned docs"
step's if condition is too broad and should match the same guards used by the
"mike deploy new version" logic; update the step's if to require
github.event_name == 'workflow_dispatch' || (github.event_name == 'release' &&
github.event.action == 'published' && !github.event.release.draft &&
(startsWith(github.event.release.name, 'v') || github.event.release.name ==
'nightly')) so the Reo/Scarf edits only run for the same release cases that
trigger "mike deploy new version".
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/build-docs.yml:
- Around line 159-162: The workflow step "Use latest template overrides from
main" writes to docs/overrides/main.html but doesn't ensure the docs/overrides
directory exists, so the redirect will fail for older tags; fix it by adding a
preceding command in that step to create the directory (ensure docs/overrides
exists before running git show origin/main:docs/overrides/main.html >
docs/overrides/main.html) so the redirect can write the file successfully.
Prepare
Description
Target issue
closes #issue-number-here
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.Closes #13233,
Summary by CodeRabbit
Documentation
New Features
Chores