docs: fixes #5984
Merged
docs: fixes #5984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-auto
added
area-documentation
|
[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!
|
yuriyz
previously approved these changes
Sep 8, 2023
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
moabu
requested changes
Sep 11, 2023
| Below is an illustration of the Janssen Server's default FIDO2 login page: | ||
|
|
||
|  | ||
|  |
Member
There was a problem hiding this comment.
Leave as is. The assets are generated.
| A user's FIDO2 devices can be removed by a Janssen administrator in LDAP under the user entry as shown in the below screenshot. | ||
|
|
||
|  | ||
|  |
Member
There was a problem hiding this comment.
Leave as is. The assets are generated
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
moabu
requested changes
Sep 17, 2023
|
|
||
| This document explains how to use the Janssen Auth Server's built-in | ||
| [FIDO2 interception script](https://github.com/JanssenProject/jans/blob/vreplace-janssen-version/jans-linux-setup/jans_setup/static/extension/person_authentication/Fido2ExternalAuthenticator.py) | ||
| [FIDO2 interception script](https://github.com/JanssenProject/jans/blob/v1.0.16/docs/script-catalog/person_authentication/fido2-external-authenticator/Fido2ExternalAuthenticator.py) |
Member
There was a problem hiding this comment.
You will break the auto doc generator and the docs will be outdated. Please do not remove the special keywords like vreplace-janssen-version with any specific version in head. This goes for there other locations in which this has occurred
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
moabu
requested changes
Oct 18, 2023
|
|
||
|  | ||
|
|
||
| The design is being rendered from the [FIDO2 xhtml page](https://github.com/JanssenProject/jans/blob/vreplace-janssen-version/jans-auth-server/server/src/main/webapp/auth/fido2/login.xhtml). To customize the look and feel of this page, follow the [customization guide](https://jans.io/docs/admin/developer/customization/customize-web-pages/). |
Member
There was a problem hiding this comment.
Please use vreplace-janssen-version instead of head
docs/admin/terraform/README.md
Outdated
|
|
||
| - **K8s:** | ||
| 1. client_id: `kubectl get cm cn -n <namespace> -o yaml | grep test_client_id` | ||
| 1. client_id: `kubectl get cm cn -n <namespace> --template={{.data.jca_client_id}}` |
Member
There was a problem hiding this comment.
you can now use the test_client_id as thats working. You can add the jca as a fallback
moabu
approved these changes
Oct 18, 2023
devrimyatar
pushed a commit
that referenced
this pull request
Dec 30, 2023
* docs: fixes * docs: fixes Signed-off-by: Amro Misbah <amromisba7@gmail.com> * docs: fix urls Signed-off-by: Amro Misbah <amromisba7@gmail.com> * docs: terraform fixes Signed-off-by: Amro Misbah <amromisba7@gmail.com> * docs: add vreplace-janssen-version Signed-off-by: Amro Misbah <amromisba7@gmail.com> * docs: change to test client and change head --------- Signed-off-by: Amro Misbah <amromisba7@gmail.com> Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
Target issue
closes #issue-number-here
Implementation Details
Test and Document the changes
Closes #5985,