Skip to content

Add Times Internet logo to the list of users.#40

Merged
mbrukman merged 1 commit intoJanusGraph:masterfrom
mbrukman:add-timesinternet-logo
Apr 22, 2018
Merged

Add Times Internet logo to the list of users.#40
mbrukman merged 1 commit intoJanusGraph:masterfrom
mbrukman:add-timesinternet-logo

Conversation

@mbrukman
Copy link
Copy Markdown
Member

@mbrukman mbrukman commented Apr 11, 2018

/cc: @pankajydv — please review and approve.

Adding per request from @pankajydv; see use case description via janusgraph-users@.

Here's a preview of what this will look like once submitted.

Copy link
Copy Markdown

@pankajydv pankajydv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt="Seeq" part should be changed to alt="Times Internet"

Copy link
Copy Markdown

@pankajydv pankajydv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, the correct logo is https://github.com/pankajydv/timesinternet/raw/master/timesinternet_logo.png. The product team has told me that the earlier logo (in 2 lines) is not the correct one, our logo is on one line.

@mbrukman mbrukman force-pushed the add-timesinternet-logo branch from 4c81dd1 to 94d6f35 Compare April 11, 2018 15:24
@mbrukman
Copy link
Copy Markdown
Member Author

@pankajydv wrote:

alt="Seeq" part should be changed to alt="Times Internet"

My apologies, of course it should! Sorry about the late-night copy-paste error. Fixed.

My apologies, the correct logo is https://github.com/pankajydv/timesinternet/raw/master/timesinternet_logo.png. The product team has told me that the earlier logo (in 2 lines) is not the correct one, our logo is on one line.

Also fixed in the latest update, but the logo is now quite small because it's so wide (a two-line logo looks better at smaller sizes). I'm experimenting with making it more readable by making it wider; will post an update once I have something better.

@pankajydv
Copy link
Copy Markdown

Thanks for your efforts @mbrukman.

Copy link
Copy Markdown

@pankajydv pankajydv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

@mbrukman mbrukman force-pushed the add-timesinternet-logo branch from 94d6f35 to bccb137 Compare April 11, 2018 17:16
@mbrukman
Copy link
Copy Markdown
Member Author

Updated logo width to be 250px so that it looks nicer; see preview for the latest version.

Ready for review and merge.

@pankajydv
Copy link
Copy Markdown

Hi, @amcp / @pluradj can you please approve. The other pull request for adding TimesInternet as production users is already merged. Please merge this logo as well. Thanks.

@mbrukman mbrukman requested a review from hsaputra April 22, 2018 02:43
Copy link
Copy Markdown
Member

@hsaputra hsaputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbrukman mbrukman force-pushed the add-timesinternet-logo branch from bccb137 to 47df26d Compare April 22, 2018 15:02
Signed-off-by: Misha Brukman <mbrukman@google.com>
@mbrukman
Copy link
Copy Markdown
Member Author

FYI, @pankajydv, I updated the URL behind the Times Internet logo to point to the JanusGraph blog post so it points to the same blog post as in https://github.com/JanusGraph/janusgraph/#users and folks can get the same context regarding the JanusGraph use case — is that OK?

@pankajydv
Copy link
Copy Markdown

Yes that's absolutely fine. Thanks!

@mbrukman mbrukman merged commit 6d17e42 into JanusGraph:master Apr 22, 2018
@mbrukman mbrukman deleted the add-timesinternet-logo branch April 22, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants