Issue #71: Various Gremlin query patterns throw NPE when query.batch=true#1000
Merged
twilmes merged 1 commit intoJanusGraph:0.2from Apr 26, 2018
Merged
Issue #71: Various Gremlin query patterns throw NPE when query.batch=true#1000twilmes merged 1 commit intoJanusGraph:0.2from
twilmes merged 1 commit intoJanusGraph:0.2from
Conversation
pluradj
requested changes
Apr 10, 2018
Member
pluradj
left a comment
pluradj
left a comment
There was a problem hiding this comment.
Thanks Ted. A few small items.
| import java.io.IOException; | ||
|
|
||
| /** | ||
| * @author Matthias Broecheler (me@matthiasb.com) |
| public class InMemoryMultiQueryGraphProvider extends AbstractJanusGraphProvider { | ||
| @Override | ||
| public ModifiableConfiguration getJanusGraphConfiguration(String graphName, Class<?> test, String testMethodName) { | ||
| return StorageSetup.getInMemoryConfiguration(); |
Member
There was a problem hiding this comment.
missing .set(GraphDatabaseConfiguration.USE_MULTIQUERY, true)
| TraversalHelper.replaceStep(localStep, vstep, traversal); | ||
|
|
||
| if (useMultiQuery) { | ||
| if (useMultiQuery) {// && !(isChildOf(vstep, MULTIQUERY_INCOMPATIBLE_STEPS))) { |
Member
There was a problem hiding this comment.
Why is this code commented out?
|
|
||
| clopen(option(USE_MULTIQUERY), true); | ||
| gts = graph.traversal(); | ||
| List<Vertex> results = gts.V(sv[0]).emit().repeat(__.barrier().out("knows")).toList(); |
Contributor
Author
There was a problem hiding this comment.
This was leftover from some debugging and shouldn't have been included. I'll get rid of it as this combo of steps is covered by the TP test suite.
pluradj
approved these changes
Apr 25, 2018
Member
|
@twilmes please squash before merging, thanks |
…ery.batch=true Storage adapter tests were added to exercise all backends in query.batch mode. The JanusGraphLocalQueryOptimizerStrategy was updated to disable multiquery on Janus specific steps that are nested within RepeatStep, MatchStep, and BranchSteps.
Contributor
Author
|
@pluradj I got them squashed. I'll merge after tests complete. I lost track of where we landed on keeping master in sync. I seem to remember merging 0.2 into master previously. Is that still the process or are we cherry picking commits? |
bwatson-rti-org
pushed a commit
to bwatson-rti-org/janusgraph
that referenced
this pull request
Mar 9, 2019
Issue JanusGraph#71: Various Gremlin query patterns throw NPE when query.batch=true
micpod
pushed a commit
to micpod/janusgraph
that referenced
this pull request
Nov 5, 2019
Issue JanusGraph#71: Various Gremlin query patterns throw NPE when query.batch=true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage adapter tests were added to exercise all backends in
query.batchmode.The
JanusGraphLocalQueryOptimizerStrategywas updated to disable multiquery on Janus specific steps that are nested withinRepeatStep,MatchStep, andBranchSteps.These steps cause difficulties with the barrier step nature of the batched query multiquery enabled steps. We should still be able to get at least some level of batched backend retrieval working with these but it will be a more involved effort. The intent of this PR is to un-break the
query.batchoption for users and to allow them to benefit from the decreased latencies in other common query patterns and to lay down a foundation for testing out further multiquery optimizations.Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master)?For code changes:
For documentation related changes:
[skip ci]tag to the first line of your commit message to avoid spending CPU cycles in
Travis CI when no code, tests, or build configuration are modified?
Note:
Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.