Skip to content

No longer use COMPACT STORAGE for Cassandra 3+ with CQL backend#1135

Merged
pluradj merged 1 commit intoJanusGraph:0.2from
pluradj:issue-1023
Jul 9, 2018
Merged

No longer use COMPACT STORAGE for Cassandra 3+ with CQL backend#1135
pluradj merged 1 commit intoJanusGraph:0.2from
pluradj:issue-1023

Conversation

@pluradj
Copy link
Member

@pluradj pluradj commented Jun 25, 2018

Fixes #1023

Signed-off-by: Jason Plurad pluradj@us.ibm.com

  • Added compact storage option for Cassandra 2 and earlier only. Default is to use compact storage when using Cassandra 2 and earlier, maintaining the previous behavior.
  • Updated docs to prefer CQL over Thrift going forward.
  • Updated to Cassandra 2.1.20.

Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?
  • If this PR is a documentation-only change, have you added a [skip ci]
    tag to the first line of your commit message to avoid spending CPU cycles in
    Travis CI when no code, tests, or build configuration are modified?

Note:

Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.

Fixes JanusGraph#1023

Signed-off-by: Jason Plurad <pluradj@us.ibm.com>
@pluradj pluradj added this to the Release v0.2.1 milestone Jun 25, 2018
@janusgraph-bot janusgraph-bot added the cla: yes This PR is compliant with the CLA label Jun 25, 2018
@pluradj pluradj requested a review from a team June 25, 2018 03:42
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sjudeng sjudeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. All code updates are covered by tests. Also compared new (cql) config files with existing (cassandra) variants and updates were as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This PR is compliant with the CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants