Skip to content

Update version compatibility table for 0.1.0 release #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbrukman merged 1 commit into from
Apr 6, 2017
Merged

Update version compatibility table for 0.1.0 release #176

mbrukman merged 1 commit into from
Apr 6, 2017

Conversation

@mbrukman
Copy link
Member

@mbrukman mbrukman commented Mar 31, 2017

Partially addresses issue #102 (for HBase only) as part of the upcoming 0.1.0
release.

@mbrukman mbrukman requested review from jerryjch and pluradj March 31, 2017 20:06
@janusgraph-bot janusgraph-bot added the cla: yes This PR is compliant with the CLA label Mar 31, 2017
jerryjch
jerryjch reviewed Mar 31, 2017
View reviewed changes
Copy link
Member

@jerryjch jerryjch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are here @mbrukman , could you just add 1.1.x, 1.2.x as supported?
Any versions for Bigtable?

@mbrukman mbrukman force-pushed the compat-matrix-hbase branch from 6990eb5 to c504f04 Compare March 31, 2017 22:45
@mbrukman
Copy link
Member Author

mbrukman commented Mar 31, 2017

@jerryjch — done for both. Bigtable has only a single version ("live"); noted as such in the docs.

@sjudeng
Copy link
Contributor

sjudeng commented Mar 31, 2017 •
edited
Loading

Can you also change the TinkerPop version to 3.2.x?

Also same question as in other PR ... should this be re-targeted to jg01 branch?

@jerryjch
Copy link
Member

jerryjch commented Apr 1, 2017

Good point. Should be in both jg01 and master.

@sjudeng sjudeng mentioned this pull request Apr 2, 2017
Merged
@mbrukman
Copy link
Member Author

mbrukman commented Apr 2, 2017

My recommendation would be to commit to master and then to cherry-pick / merge manually into the release branch.

I don't think we can just commit to a release branch and merge it into master (or vice versa) as master will quickly diverge from a release branch, at which point it won't cleanly merge in either direction.

@sjudeng
Copy link
Contributor

sjudeng commented Apr 2, 2017

I think the release branch can always be merged into master but not the other way around. Can we work through this on the dev list?

Also regarding Bigtable version @jerryjch made a comment on this in #184 and here I see you're using version "live" but on Maven central and in bigtable.txt I see versions of the form 0.9.x.

sjudeng
sjudeng approved these changes Apr 6, 2017
View reviewed changes
Copy link
Contributor

@sjudeng sjudeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can put in another PR to update TinkerPop version in the table if that's out of scope here.

@mbrukman
Version compatibility updates for 0.1.0 release
2f30f03 
* HBase: drop 0.94 and 0.96; add 1.1 and 1.2
* Bigtable: specify 0.9.x client library compatibility
* TinkerPop: update to 3.2.x

Addresses issue JanusGraph#102.

Signed-off-by: Misha Brukman <mbrukman@google.com>
@mbrukman
Copy link
Member Author

mbrukman commented Apr 6, 2017

@sjudeng — sorry for the delay, I was out for a few days. Will update this PR as follows:

  • rebase on the 0.1 branch
  • change Bigtable to 0.9.x (good point)
  • change TinkerPop to 3.2.x

@mbrukman mbrukman force-pushed the compat-matrix-hbase branch from c504f04 to 2f30f03 Compare April 6, 2017 16:38
@janusgraph-bot janusgraph-bot added cla: no This PR is not compliant with the CLA and removed cla: yes This PR is compliant with the CLA labels Apr 6, 2017
@janusgraph-bot
Copy link

janusgraph-bot commented Apr 6, 2017

Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

@mbrukman mbrukman changed the base branch from master to 0.1 April 6, 2017 16:40
@mbrukman mbrukman changed the title Drop HBase 0.94 and 0.96 from compatibility chart. Update version compatibility table for 0.1.0 release Apr 6, 2017
@janusgraph-bot janusgraph-bot added cla: yes This PR is compliant with the CLA and removed cla: no This PR is not compliant with the CLA labels Apr 6, 2017
@mbrukman
Copy link
Member Author

mbrukman commented Apr 6, 2017

@sjudeng — do you want to re-review this PR given the changes I made after your approval?

@sjudeng
Copy link
Contributor

sjudeng commented Apr 6, 2017

LGTM!

amcp
amcp approved these changes Apr 6, 2017
View reviewed changes
Copy link

@amcp amcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, maybe @sjudeng can debase his geoshape PR on this one after we merge this

@mbrukman mbrukman merged commit baea734 into JanusGraph:0.1 Apr 6, 2017
@mbrukman mbrukman deleted the compat-matrix-hbase branch April 6, 2017 20:40
@mbrukman mbrukman mentioned this pull request Apr 6, 2017
Closed
@sjudeng sjudeng mentioned this pull request Apr 7, 2017
Merged
bwatson-rti-org pushed a commit to bwatson-rti-org/janusgraph that referenced this pull request Mar 9, 2019
@mbrukman
Merge pull request JanusGraph#176 from mbrukman/compat-matrix-hbase
703acf4 
Update version compatibility table for 0.1.0 release
micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019
@mbrukman
Merge pull request JanusGraph#176 from mbrukman/compat-matrix-hbase
525bdf8 
Update version compatibility table for 0.1.0 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amcp amcp amcp approved these changes

@jerryjch jerryjch jerryjch approved these changes

@sjudeng sjudeng sjudeng approved these changes

@pluradj pluradj Awaiting requested review from pluradj

Assignees

No one assigned

Labels

area/docs cla: yes This PR is compliant with the CLA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mbrukman @sjudeng @jerryjch @janusgraph-bot @amcp