Issue 133: Mark JTS as optional dependency in janusgraph-solr#189
Merged
twilmes merged 1 commit intoJanusGraph:0.1from Apr 10, 2017
Merged
Issue 133: Mark JTS as optional dependency in janusgraph-solr#189twilmes merged 1 commit intoJanusGraph:0.1from
twilmes merged 1 commit intoJanusGraph:0.1from
Conversation
Signed-off-by: sjudeng <sjudeng@users.noreply.github.com>
Contributor
|
@sjudeng just want to double check, I'm good to merge this one, right? |
Contributor
Author
|
I'm good with it but I thought we needed one more review. |
Contributor
|
As we have the dev process currently, I think we're good to go: "Two committer approvals are required to merge a pull request". It's not explicitly stated, but I think the intent was that if the submitter is a committer, their vote on the PR counts towards the two approvals. I'll go ahead and merge. |
bwatson-rti-org
pushed a commit
to bwatson-rti-org/janusgraph
that referenced
this pull request
Mar 9, 2019
Issue 133: Mark JTS as optional dependency in janusgraph-solr
micpod
pushed a commit
to micpod/janusgraph
that referenced
this pull request
Nov 5, 2019
Issue 133: Mark JTS as optional dependency in janusgraph-solr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #133