Ensure Log4j is used for testing #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for test logging
Signed-off-by: sjudeng <sjudeng@users.noreply.github.com>
Signed-off-by: sjudeng <sjudeng@users.noreply.github.com>
amcp
requested changes
Feb 4, 2017
janusgraph-es/pom.xml
Outdated
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.1.2</version> |
There was a problem hiding this comment.
can we pull this version into a property someplace like the parent pom?
janusgraph-hadoop-parent/pom.xml
Outdated
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.1.2</version> |
janusgraph-hbase-parent/pom.xml
Outdated
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.1.2</version> |
janusgraph-solr/pom.xml
Outdated
| <dependency> | ||
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.1.2</version> |
Signed-off-by: sjudeng <sjudeng@users.noreply.github.com>
Contributor
Author
|
Thanks and requested updates are done |
amcp
approved these changes
Feb 4, 2017
micpod
pushed a commit
to micpod/janusgraph
that referenced
this pull request
Nov 5, 2019
Ensure Log4j is used for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log4j should be used for testing but Logback is being used in some modules (janusgraph-es, janusgraph-hadoop, janusgraph-hbase and janusgraph-solr). In these cases the log4j.properties test resources are ignored and console logging is too verbose. In a standard test run (
mvn verify) console logging exceeds 75M. With the fixes in this PR the logging output for the same run is about 3M.Note the solution was already present in janusgraph-cassandra (see logging comment in janusgraph-cassandra/pom.xml) and this PR just propagates that into the offending modules. More minor updates were to clean up some of the test log4j.properties files and ensure that these were used in relevant tests (e.g.
log4j.configurationfile).