Skip to content

support qualified table names#262

Merged
JasonShin merged 5 commits intomainfrom
fully-qualified-names
Mar 10, 2026
Merged

support qualified table names#262
JasonShin merged 5 commits intomainfrom
fully-qualified-names

Conversation

@JasonShin
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 10, 2026 08:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SQL parser’s table-name display logic to handle qualified table names by using the last identifier component, and adds demo coverage for schema-qualified tables.

Changes:

  • Update DisplayObjectName to return the last identifier for qualified names (e.g., schema.tabletable) and add Rust unit tests for the behavior.
  • Add new demo queries + snapshots to validate type generation for qualified table names and joins.
  • Change the MySQL default database name in docker-compose and the sample config.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/ts_generator/sql_parser/quoted_strings.rs Adjusts object-name rendering for qualified names and adds unit tests.
tests/demo/select/qualified_table_names.ts Adds demo SQL queries that use schema-qualified tables.
tests/demo/select/qualified_table_names.queries.ts Adds generated query typings for the new demo queries.
tests/demo/select/qualified_table_names.snapshot.ts Adds snapshot baseline for generated typings.
docker-compose.yml Changes the MySQL container’s default database name.
.sqlxrc.sample.json Updates sample MySQL connection DB name to match docker-compose.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 10, 2026 08:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JasonShin JasonShin changed the title support fully qualified names support qualified table names Mar 10, 2026
@JasonShin JasonShin enabled auto-merge (squash) March 10, 2026 08:54
Copilot AI review requested due to automatic review settings March 10, 2026 08:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JasonShin JasonShin disabled auto-merge March 10, 2026 09:53
@JasonShin JasonShin merged commit b4555ff into main Mar 10, 2026
37 checks passed
@JasonShin JasonShin deleted the fully-qualified-names branch March 10, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants