Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SQL parser’s table-name display logic to handle qualified table names by using the last identifier component, and adds demo coverage for schema-qualified tables.
Changes:
- Update
DisplayObjectNameto return the last identifier for qualified names (e.g.,schema.table→table) and add Rust unit tests for the behavior. - Add new demo queries + snapshots to validate type generation for qualified table names and joins.
- Change the MySQL default database name in docker-compose and the sample config.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/ts_generator/sql_parser/quoted_strings.rs |
Adjusts object-name rendering for qualified names and adds unit tests. |
tests/demo/select/qualified_table_names.ts |
Adds demo SQL queries that use schema-qualified tables. |
tests/demo/select/qualified_table_names.queries.ts |
Adds generated query typings for the new demo queries. |
tests/demo/select/qualified_table_names.snapshot.ts |
Adds snapshot baseline for generated typings. |
docker-compose.yml |
Changes the MySQL container’s default database name. |
.sqlxrc.sample.json |
Updates sample MySQL connection DB name to match docker-compose. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.