Conversation
Adds `SET` to be represented as a `string` in Typescript since MySQL returns back a comma delimited string, and typescript expects a comma delimited string for update/insertion.
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MySQL SET column support to the TypeScript type generator and introduces demo coverage to ensure generated types treat SET as string rather than falling back to any.
Changes:
- Map MySQL
setfields toTsFieldType::Stringin the TS generator. - Add MySQL demo queries for selecting/inserting
SETcolumns. - Add/commit corresponding
.queries.tsoutputs and.snapshot.tsexpectations for the new demos.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/demo/mysql/set_select.ts | Adds demo SELECT queries involving MySQL SET columns (including mixed-column select and WHERE param). |
| tests/demo/mysql/set_select.queries.ts | Generated TS query/result types for set_select.ts. |
| tests/demo/mysql/set_select.snapshot.ts | Snapshot for generated output of set_select.queries.ts. |
| tests/demo/mysql/set_insert.ts | Adds demo INSERT queries involving MySQL SET columns (single/multi-column and multi-row). |
| tests/demo/mysql/set_insert.queries.ts | Generated TS query/result types for set_insert.ts. |
| tests/demo/mysql/set_insert.snapshot.ts | Snapshot for generated output of set_insert.queries.ts. |
| src/ts_generator/types/ts_query.rs | Implements MySQL type mapping change: set → string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.