Support projection side effects on Inline projections (#99)#101
Merged
Conversation
Promotes EnableSideEffectsOnInlineProjections from a hardcoded false to a configurable setting on EventGraph. When the flag is on: - RaiseSideEffects() runs for projections registered with the Inline lifecycle (the gate inside JFx.Events' projection bases reads IStorageOperations.EnableSideEffectsOnInlineProjections). - slice.PublishMessage(...) routes through the configured IMessageOutbox via a new GetOrStartMessageSink() impl on DocumentSessionBase, lazily creating an IMessageBatch on first publish and reusing it for the rest of the session's commit. - The session's SaveChangesInternalAsync calls BeforeCommitAsync on the message batch inside the SQL transaction (right before tx.CommitAsync) and AfterCommitAsync once after the commit + listeners have run. slice.AppendEvent(...) from an inline RaiseSideEffects override is disallowed at the JFx.Events level (throws InvalidOperationException). Test coverage in src/Polecat.Tests/Events/inline_projection_side_effects_tests.cs: flag-off no-op, flag-on publish round-trip, lifecycle ordering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes EnableSideEffectsOnInlineProjections from a hardcoded false to a configurable setting on EventGraph. When the flag is on:
slice.AppendEvent(...) from an inline RaiseSideEffects override is disallowed at the JFx.Events level (throws InvalidOperationException).
Test coverage in src/Polecat.Tests/Events/inline_projection_side_effects_tests.cs: flag-off no-op, flag-on publish round-trip, lifecycle ordering.