Polecat#46: Tighten reflective surface annotations from class-level to call-site

[jeremydmiller]

Summary

Replaces class-level [UnconditionalSuppressMessage] umbrellas on Polecat's reflective surfaces with method-level annotations that name the exact contract. Downstream IsAotCompatible=true consumers now see a precise punch-list instead of a wall of silenced classes. Ticks the "Audit reflective surfaces that aren't covered by Polecat.CodeGeneration. Annotate or migrate." checkbox on #46.

Polecat.AotSmoke (from #102/#106) still builds clean — the gate confirms no AOT regression.

Before/after

File	Class-level attrs (before)	Class-level attrs (after)	Method-level attrs added
Projections/PolecatCompositeProjection.cs	2 (IL2026, IL3050)	0	2 on Snapshot<T>
Projections/PolecatProjectionOptions.cs	2 (IL2026, IL3050)	0	4 across Snapshot<T> + AddSnapshotProjection<T>
Linq/PolecatLinqQueryProvider.cs	4 (IL2026, IL2070, IL2075, IL3050)	0	25 across 12 methods (CreateQuery, ExecuteAsync, ExecuteGroupBy/ExecuteGroupJoin, all Invoke*Handler*Async, FindOriginalProperty, FindDeepestMemberExpression, RebuildMemberAccess)
Events/Linq/EventLinqQueryProvider.cs (sibling)	2 (IL2075, IL3050)	0	14 across 6 methods
Internal/DocumentSessionBase.cs	2 (IL2026, IL3050)	0	2 method-level UnconditionalSuppressMessage on InsertEventAsync
Linq/IPolecatAsyncQueryProvider.cs (propagation)	0	0	2 on the interface ExecuteAsync<TResult> so impls match

Why method-level UnconditionalSuppressMessage on DocumentSessionBase instead of RUC/RDC?
The reflective surface in DocumentSessionBase is two Serializer.ToJson(object) call sites in InsertEventAsync (a private method). Promoting [RUC]/[RDC] up the call chain would propagate to IDocumentSession.SaveChangesAsync — a public interface change beyond #46's scope. Per the chip's style guide, method-level UnconditionalSuppressMessage is the documented fallback when "no method-level annotation expresses the constraint cleanly" — in this case "cleanly" includes "without widening scope to the public surface." Justifications name the exact call sites.

EventLinqQueryProvider wasn't in the chip's primary four but came in scope because adding RUC/RDC to IPolecatAsyncQueryProvider.ExecuteAsync (required to match PolecatLinqQueryProvider's impl annotation) cascaded an IL2046 mismatch on the only other implementer. Tightening both impls + the interface in one go is cleaner than leaving the sibling with a stale class-level umbrella.

Verification

• dotnet build src/Polecat/Polecat.csproj -c Release — clean (same 7 pre-existing IL warnings as main, all in files outside this PR's scope; no new warnings introduced)
• dotnet build src/Polecat.AotSmoke/Polecat.AotSmoke.csproj -c Release — clean (0 warnings, 0 errors on net9.0 + net10.0); smoke surface migrated from opts.Projections.Snapshot<Quest>(...) (now correctly RUC/RDC) to the AOT-safe opts.Projections.Add<QuestProjection>(ProjectionLifecycle.Inline) pattern with a concrete SingleStreamProjection<Quest, Guid> subclass
• dotnet build src/Polecat.EntityFrameworkCore.Tests/Polecat.EntityFrameworkCore.Tests.csproj -c Release — clean (only pre-existing CS8767 nullability noise unrelated to AOT)
• dotnet run --project src/Polecat.AotSmoke -c Release — exits 0 on both net9.0 + net10.0

Local test suite couldn't be run end-to-end — the Docker SQL Server image is linux/amd64 and the host is arm64, so emulated connection handshakes time out before tests can even open a connection (every test fails at ConnectionSource.DetectNativeJsonSupport() with Connection Timeout Expired, handshake=3881ms). All test failures are environmental; the changes are annotation-only with no runtime semantics, so the existing CI run on amd64 is the authoritative verification.

Out of scope (per chip's "Don't widen scope")

Pre-existing class-level suppressions remain in: DocumentStore.{EventStoreExplorer,ProjectionReplay}.cs, AdvancedOperations.cs, AdvancedSqlResultReader.cs, Serialization/Serializer.cs, Events/EventGraph.cs, Events/EventOperations.cs, Events/Daemon/PolecatEventLoader.cs, Events/Internal/PcEventsRowReader.cs, Internal/QuerySession.cs, Internal/DocumentProvider*.cs, Internal/Batching/*.cs, Storage/DocumentMapping*.cs, Linq/{NonStaleDataExtensions,SoftDeletes/SoftDeletedExtensions,Metadata/*,Selectors/DeserializingSelector,Joins/JoinResultSelectorRewriter,Parsing/*,QueryHandlers/*,PolecatQueryableExtensions,LinqExtensions}.cs, Patching/*.cs, Projections/{PolecatProjectionStorage,Flattened/{StatementMap,EventDeleter}}.cs, PolecatConfigurationExpression.cs, PolecatStoreServiceCollectionExtensions.cs. A follow-up chip can sweep these.

Also out of scope: migrating reflective patterns to GenericFactoryCache / source generators (separate Polecat#46 checkbox under the cold-start pillar).

Commit shape

1. ae97c3b — Projections cluster (PolecatCompositeProjection + PolecatProjectionOptions) + AotSmoke surface migration
2. 112da8b — LINQ providers (PolecatLinqQueryProvider + IPolecatAsyncQueryProvider + EventLinqQueryProvider sibling)
3. b1de9f6 — DocumentSessionBase

References #46.

🤖 Generated with Claude Code