Closed
Conversation
…postgres and view declaration without semicolon
…ng partitions to sidestep table dead locks when dropping partitions across tables. Closes JasperFxGH-174
Contributor
Author
|
Should I do sth about this conflict or leave it to you @jeremydmiller ? |
Member
|
Closing — the deadlock fix has been cherry-picked into a fresh branch against current master. Thank you @netijoe for identifying this issue! The fix is in PR #(pending). |
jeremydmiller
added a commit
that referenced
this pull request
Apr 9, 2026
Move the double-check of _hasInitialized and _partitions.Clear() inside the try block after acquiring the semaphore. Previously, if two threads entered WaitAsync simultaneously, the second could bypass the semaphore guard and proceed without the lock held. Based on the fix identified in #181 by @netijoe. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
jeremydmiller
added a commit
that referenced
this pull request
Apr 9, 2026
Move the double-check of _hasInitialized and _partitions.Clear() inside the try block after acquiring the semaphore. Previously, if two threads entered WaitAsync simultaneously, the second could bypass the semaphore guard and proceed without the lock held. Based on the fix identified in #181 by @netijoe. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled upon neverending wait in this place during integration test run for my project.