Fix some usages of HttpChain.RequestType after filling it with System.Void as default value#847
Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom Apr 29, 2024
Conversation
….Void as default value
Member
|
@haefele Sigh, and thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this change lead to some changes in the OpenAPI generation (see my change in
HttpChain.ApiDescription).It leads to endpoints without a request having a "made up" request with type
System.Void, which in turn trips up Swashbuckle.To me, it seems like that wasn't the intention with the
RequestType ??= typeof(void)so I made these adjustments.I also checked the other usages of the
RequestTypeproperty and tried to adjust them if needed.