Skip to content

Conversation

@danthe1st
Copy link
Member

@danthe1st danthe1st commented Dec 21, 2022

This Pull Request

  • removes @Nullable for null-checked variable
  • Makes sure that /purge stops after not deleting any messages 20 times
  • make sure not to delete more than amount messages (Previously, it always loaded amount (or 100 if amount is greater than that) messages from the channel even if some messages have already been deleted)
  • load a bit more message when clearing messages from a particular user
  • use channel#purgeMessages for bulk-deletion

Alternatives considered

  • make the number of empty iterations to stop purging configurable
  • make the amount of messages to load in case of deleting messages from particular users configurable

@danthe1st danthe1st requested a review from a team as a code owner December 21, 2022 12:17
@jasonlessenich jasonlessenich merged commit 98a06b6 into Java-Discord:main Jan 15, 2023
@danthe1st danthe1st deleted the purge branch January 16, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants