Change minimum xp for daily removal to 1 #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danthe1st
approved these changes
Jan 16, 2024
Member
danthe1st
left a comment
danthe1st
left a comment
There was a problem hiding this comment.
It would e nice if you could also add options for the minimum XP and maximum XP in the HelpConfig and initialize them with 1 and 50 respectively.
danthe1st
added
the
feature: help-system
danthe1st
requested changes
Jan 26, 2024
Member
There was a problem hiding this comment.
Please check the changes I proposed in liquiddevelopmentnet#1.
If these are merged, this PR should automatically update.
configurability, improve precision, tests of daily XP subtraction
danthe1st
approved these changes
Jan 26, 2024
MoonTM-GIT
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the amount of minimum XP that has to be removed daily from
5to1.@danthe1st