Skip to content

configurability, improve precision, tests of daily XP subtraction #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2024
Merged

configurability, improve precision, tests of daily XP subtraction #1

merged 4 commits into from
Jan 26, 2024

Conversation

@danthe1st
Copy link

@danthe1st danthe1st commented Jan 26, 2024

This PR adds the following improvements to Java-Discord#476:

  • The min and max limits are made configurable
  • In order to avoid precision and possible integer division issues (in case the ratio is actually an integer), the experience is multiplied with the fraction to subtract before dividing by 100
  • tests for XP subtraction

@danthe1st danthe1st mentioned this pull request Jan 26, 2024
Merged
@liquiddevelopmentnet liquiddevelopmentnet merged commit 8af2ac3 into liquiddevelopmentnet:min-xp Jan 26, 2024
@danthe1st danthe1st deleted the liquiddevelopmentnet-min-xp branch January 26, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liquiddevelopmentnet liquiddevelopmentnet liquiddevelopmentnet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danthe1st @liquiddevelopmentnet