Skip to content

Wrong constant used in ConversionQueryBuilder #66

@dominik42

Description

@dominik42

The javax.money.convert.ConversionQueryBuilder uses a wrong ConversionQuery constant for one of the set methods:

public ConversionQueryBuilder setRateTypes(RateType... rateTypes) {
    return set("rateTypes", new HashSet<>(Arrays.asList(rateTypes)));
}

The string rateTypes should be Query.rateTypes or, far better, the string constant ConversionQuery.KEY_RATE_TYPES as used few lines below:

public ConversionQueryBuilder setRateTypes(Set<RateType> rateTypes) {
    return set(ConversionQuery.KEY_RATE_TYPES, rateTypes);
}

With this bug, the usage of queryBuilder.setRateTypes(RateType.HISTORIC); isn't possible, due to the underlying map doesn't contain a value for Query.rateTypes in the end.

kind regards
Dominik

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions