Skip to content

Improve SubscriptionServie, part 1 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 6, 2025
Merged

Improve SubscriptionServie, part 1 #50

merged 12 commits into from
Nov 6, 2025

Conversation

@JavaSaBr
Copy link
Owner

@JavaSaBr JavaSaBr commented Nov 6, 2025

Improve SubscriptionServie, part 1

@JavaSaBr JavaSaBr self-assigned this Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Overall Project 84.54% -6.94% 🍏
Files changed 82.87% 🍏

File Coverage
RequestedSubscription.java 100% 🍏
Subscription.java 100% 🍏
TrackableMqttInMessage.java 100% 🍏
MqttClientConnectionConfig.java 100% 🍏
MqttProperties.java 100% 🍏
SingleSubscriber.java 100% 🍏
Subscriber.java 100% 🍏
ConcurrentTopicTree.java 100% 🍏
PublishCompleteMqtt5OutMessage.java 100% 🍏
SubscribeAckMqtt5OutMessage.java 100% 🍏
TrackableMqttOutMessage.java 100% 🍏
PublishAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
SubscribeMqtt311OutMessage.java 100% 🍏
PublishReleaseMqtt5OutMessage.java 100% 🍏
SubscribeAckMqtt311OutMessage.java 100% 🍏
PublishAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt5OutMessage.java 100% 🍏
PublishMqtt5OutMessage.java 100% 🍏
DisconnectMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt5OutMessage.java 100% 🍏
SubscribeMqtt5OutMessage.java 100% 🍏
PublishMqttOutMessage.java 100% 🍏
PendingOutResponseMqttInMessageHandler.java 100% 🍏
PublishReceiveMqttInMessageHandler.java 100% 🍏
PublishCompleteMqttInMessageHandler.java 100% 🍏
PublishAckMqttInMessageHandler.java 100% 🍏
PublishReleaseMqttInMessageHandler.java 100% 🍏
TopicFilter.java 100% 🍏
SharedTopicFilter.java 100% 🍏
SubscriptionService.java 100% 🍏
MqttDataType.java 100% 🍏
Qos0MqttPublishOutMessageHandler.java 100% 🍏
DisconnectReasonCode.java 100% 🍏
SubscribeAckReasonCode.java 100% 🍏
TopicTreeBase.java 99.04% -0.96% 🍏
TopicNode.java 98.78% -1.22% 🍏
Publish.java 98.53% -1.47% 🍏
PublishReceivedMqttInMessage.java 96.34% 🍏
PublishCompleteMqttInMessage.java 96.34% 🍏
PublishReleaseMqttInMessage.java 96.34% 🍏
MqttMessageProperty.java 96.19% -3.81% 🍏
PublishAckMqttInMessage.java 96.1% 🍏
ConnectAckMqttInMessage.java 95.97% 🍏
QoS.java 95.92% 🍏
PayloadFormat.java 95.92% -4.08% 🍏
PublishMqttInMessage.java 95.83% 🍏
AuthenticationMqtt5OutMessage.java 95.74% 🍏
TopicValidator.java 94.62% -5.38% 🍏
DisconnectMqttInMessage.java 94.17% 🍏
UnsubscribeAckMqttInMessage.java 92.31% 🍏
PersistedMqttPublishOutMessageHandler.java 92% -2.67% 🍏
AbstractTopic.java 91.96% 🍏
SharedSubscriber.java 91.58% -4.21% 🍏
MqttOutMessage.java 90.48% 🍏
MqttBrokerSpringConfig.java 89.52% 🍏
AuthenticationMqttInMessage.java 88.24% 🍏
ConnectMqtt5OutMessage.java 87.89% 🍏
ConnectMqttInMessage.java 87.69% 🍏
SubscribeMqttInMessageHandler.java 87.42% -12.58% 🍏
AbstractMqttClient.java 87.23% 🍏
MqttInMessage.java 85.83% -3.74% ❌
Mqtt5MessageOutFactory.java 84.82% -7.14% 🍏
SubscribeMqttInMessage.java 84% -14.29% 🍏
DefaultPublishReceivingService.java 83.77% -11.52% 🍏
DefaultPublishDeliveringService.java 83.33% 🍏
AbstractMqttClientReleaseHandler.java 83.19% 🍏
SubscribeAckMqttInMessage.java 82.89% 🍏
TopicName.java 82.35% -17.65% 🍏
DebugUtils.java 81.38% -9.57% ❌
MqttServerConnectionConfig.java 80.24% -19.76% 🍏
Qos2MqttPublishOutMessageHandler.java 79.41% 🍏
ConnectInMqttInMessageHandler.java 78.77% -8.22% 🍏
AbstractMqttPublishOutMessageHandler.java 78.64% -19.42% 🍏
InMemoryMqttSessionService.java 78.57% 🍏
UnsubscribeMqttInMessage.java 73.68% -22.81% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
InMemoryMqttSession.java 70.8% -13.7% 🍏
Mqtt311MessageOutFactory.java 69.12% -7.35% 🍏
Qos1MqttPublishOutMessageHandler.java 63.16% 🍏
MqttMessageOutFactory.java 61.64% -15.75% ❌
Qos2MqttPublishInMessageHandler.java 60.5% -17.65% ❌
InMemorySubscriptionService.java 54.81% -45.19% ❌
PublishMqttInMessageHandler.java 52.05% -47.95% ❌
AbstractMqttPublishInMessageHandler.java 51.33% -38.94% ❌
AbstractMqttInMessageHandler.java 47.12% -35.58% ❌
Qos1MqttPublishInMessageHandler.java 41.59% -44.25% ❌
DefaultTopicService.java 34.85% -65.15% ❌
UnsubscribeMqttInMessageHandler.java 27.45% -56.86% ❌
MqttSession.java 0% ❌
ConnectionRejectException.java 0% 🍏
MalformedProtocolMqttException.java 0% ❌

@JavaSaBr JavaSaBr merged commit e871b2e into develop Nov 6, 2025
6 checks passed
@JavaSaBr JavaSaBr deleted the improve-subscribtion-implementation branch November 6, 2025 06:10
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Overall Project 83.73% -6.97% 🍏
Files changed 82.8% 🍏

File Coverage
RequestedSubscription.java 100% 🍏
Subscription.java 100% 🍏
TrackableMqttInMessage.java 100% 🍏
MqttClientConnectionConfig.java 100% 🍏
MqttProperties.java 100% 🍏
SingleSubscriber.java 100% 🍏
Subscriber.java 100% 🍏
ConcurrentTopicTree.java 100% 🍏
PublishCompleteMqtt5OutMessage.java 100% 🍏
SubscribeAckMqtt5OutMessage.java 100% 🍏
TrackableMqttOutMessage.java 100% 🍏
PublishAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
SubscribeMqtt311OutMessage.java 100% 🍏
PublishReleaseMqtt5OutMessage.java 100% 🍏
SubscribeAckMqtt311OutMessage.java 100% 🍏
PublishAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt5OutMessage.java 100% 🍏
PublishMqtt5OutMessage.java 100% 🍏
DisconnectMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt5OutMessage.java 100% 🍏
SubscribeMqtt5OutMessage.java 100% 🍏
PublishMqttOutMessage.java 100% 🍏
PendingOutResponseMqttInMessageHandler.java 100% 🍏
PublishReceiveMqttInMessageHandler.java 100% 🍏
PublishCompleteMqttInMessageHandler.java 100% 🍏
PublishAckMqttInMessageHandler.java 100% 🍏
PublishReleaseMqttInMessageHandler.java 100% 🍏
TopicFilter.java 100% 🍏
SharedTopicFilter.java 100% 🍏
SubscriptionService.java 100% 🍏
MqttDataType.java 100% 🍏
Qos0MqttPublishOutMessageHandler.java 100% 🍏
DisconnectReasonCode.java 100% 🍏
SubscribeAckReasonCode.java 100% 🍏
TopicTreeBase.java 99.04% -0.96% 🍏
TopicNode.java 98.78% -1.22% 🍏
Publish.java 98.53% -1.47% 🍏
PublishReceivedMqttInMessage.java 96.34% 🍏
PublishCompleteMqttInMessage.java 96.34% 🍏
PublishReleaseMqttInMessage.java 96.34% 🍏
MqttMessageProperty.java 96.19% -3.81% 🍏
PublishAckMqttInMessage.java 96.1% 🍏
ConnectAckMqttInMessage.java 95.97% 🍏
QoS.java 95.92% 🍏
PayloadFormat.java 95.92% -4.08% 🍏
PublishMqttInMessage.java 95.83% 🍏
AuthenticationMqtt5OutMessage.java 95.74% 🍏
TopicValidator.java 94.62% -5.38% 🍏
DisconnectMqttInMessage.java 94.17% 🍏
UnsubscribeAckMqttInMessage.java 92.31% 🍏
PersistedMqttPublishOutMessageHandler.java 92% -2.67% 🍏
AbstractTopic.java 91.96% 🍏
SharedSubscriber.java 91.58% -4.21% 🍏
MqttOutMessage.java 90.48% 🍏
MqttBrokerSpringConfig.java 89.52% 🍏
AuthenticationMqttInMessage.java 88.24% 🍏
ConnectMqtt5OutMessage.java 87.89% 🍏
ConnectMqttInMessage.java 87.69% 🍏
SubscribeMqttInMessageHandler.java 87.42% -12.58% 🍏
AbstractMqttClient.java 87.23% 🍏
MqttInMessage.java 85.83% -3.74% ❌
Mqtt5MessageOutFactory.java 84.82% -7.14% 🍏
SubscribeMqttInMessage.java 84% -14.29% 🍏
DefaultPublishReceivingService.java 83.77% -11.52% 🍏
DefaultPublishDeliveringService.java 83.33% 🍏
AbstractMqttClientReleaseHandler.java 83.19% 🍏
SubscribeAckMqttInMessage.java 82.89% 🍏
TopicName.java 82.35% -17.65% 🍏
DebugUtils.java 81.38% -9.57% ❌
MqttServerConnectionConfig.java 80.24% -19.76% 🍏
Qos2MqttPublishOutMessageHandler.java 79.41% 🍏
ConnectInMqttInMessageHandler.java 78.77% -8.22% 🍏
AbstractMqttPublishOutMessageHandler.java 78.64% -19.42% 🍏
UnsubscribeMqttInMessage.java 73.68% -22.81% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
Mqtt311MessageOutFactory.java 69.12% -7.35% 🍏
InMemoryMqttSession.java 67.18% -13.7% 🍏
Qos1MqttPublishOutMessageHandler.java 63.16% 🍏
MqttMessageOutFactory.java 61.64% -15.75% ❌
Qos2MqttPublishInMessageHandler.java 60.5% -17.65% ❌
InMemorySubscriptionService.java 54.81% -45.19% ❌
PublishMqttInMessageHandler.java 52.05% -47.95% ❌
AbstractMqttPublishInMessageHandler.java 51.33% -38.94% ❌
AbstractMqttInMessageHandler.java 47.12% -35.58% ❌
InMemoryMqttSessionService.java 46.6% -1.36% ❌
Qos1MqttPublishInMessageHandler.java 41.59% -44.25% ❌
DefaultTopicService.java 34.85% -65.15% ❌
UnsubscribeMqttInMessageHandler.java 27.45% -56.86% ❌
MqttSession.java 0% ❌
ConnectionRejectException.java 0% 🍏
MalformedProtocolMqttException.java 0% ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JavaSaBr JavaSaBr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JavaSaBr