Skip to content

Improve publish implementation, part 2 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JavaSaBr merged 10 commits into from
Nov 22, 2025
Merged

Improve publish implementation, part 2 #56

JavaSaBr merged 10 commits into from
Nov 22, 2025

Conversation

@JavaSaBr
Copy link
Owner

@JavaSaBr JavaSaBr commented Nov 21, 2025

Finish rewriting the implementation of delivering QoS 0-2 messages from client to server.

@JavaSaBr JavaSaBr requested a review from crazyrokr November 21, 2025 18:32
@JavaSaBr JavaSaBr self-assigned this Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Overall Project 85.8% -2.69% 🍏
Files changed 73.09% 🍏

File Coverage
QoS.java 100% 🍏
PublishCompleteMqtt5OutMessage.java 100% 🍏
PublishReleaseMqtt311OutMessage.java 100% 🍏
DisconnectMqtt311OutMessage.java 100% 🍏
PublishAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
SubscribeMqtt311OutMessage.java 100% 🍏
PublishReleaseMqtt5OutMessage.java 100% 🍏
PublishCompleteMqtt311OutMessage.java 100% 🍏
PublishMqtt311OutMessage.java 100% 🍏
SubscribeAckMqtt311OutMessage.java 100% 🍏
PublishAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt5OutMessage.java 100% 🍏
PublishMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt311OutMessage.java 100% 🍏
PublishReceiveMqttInMessageHandler.java 100% 🍏
PublishCompleteMqttInMessageHandler.java 100% 🍏
PublishAckMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
UnsubscribeMqttInMessageHandler.java 100% 🍏
TrackableMqttPublishInMessageHandler.java 100% 🍏
PublishAckReasonCode.java 100% 🍏
PublishReceivedReasonCode.java 100% 🍏
PublishCompletedReasonCode.java 100% 🍏
InMemoryActiveSubscriptions.java 100% 🍏
Publish.java 98.77% 🍏
PublishMqttInMessageHandler.java 97.62% -0.73% 🍏
SubscribeMqttInMessage.java 97.44% 🍏
PublishMqttInMessage.java 96.81% 🍏
InMemorySubscriptionService.java 96.59% 🍏
PublishReceivedMqttInMessage.java 96.34% 🍏
PublishCompleteMqttInMessage.java 96.34% 🍏
PublishAckMqttInMessage.java 96.1% 🍏
ConnectAckMqttInMessage.java 95.97% 🍏
AuthenticationMqtt5OutMessage.java 95.74% 🍏
PublishReleaseMqttInMessage.java 94.87% 🍏
UnsubscribeAckReasonCode.java 94.55% 🍏
DisconnectMqttInMessage.java 94.17% 🍏
ConnectAckReasonCode.java 93.21% 🍏
UnsubscribeAckMqttInMessage.java 92.31% 🍏
UnsubscribeMqttInMessage.java 92.31% 🍏
InMemoryTopicNameMapping.java 92.06% 🍏
AuthenticateReasonCode.java 92% 🍏
PublishReleaseReasonCode.java 92% 🍏
Mqtt5MessageOutFactory.java 91.67% 🍏
MqttMessageReader.java 90.14% 🍏
MqttBrokerSpringConfig.java 89.57% 🍏
MqttMessageType.java 88.39% 🍏
AuthenticationMqttInMessage.java 88.24% 🍏
ConnectMqttInMessage.java 87.69% 🍏
InMemoryMessageTacker.java 87.04% -12.96% 🍏
UnsubscribeAckMqtt311OutMessage.java 84.62% 🍏
DefaultPublishReceivingService.java 83.77% -11.52% ❌
SubscribeAckMqttInMessage.java 81.16% 🍏
ConnectInMqttInMessageHandler.java 80.58% -0.73% ❌
AbstractMqttPublishOutMessageHandler.java 77.78% 🍏
Qos1MqttPublishInMessageHandler.java 75.94% -24.06% 🍏
PublishRetryer.java 75% -25% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
InMemoryProcessingPublishes.java 73.23% -26.77% 🍏
ConnectMqtt311OutMessage.java 72.99% 🍏
Mqtt311MessageOutFactory.java 69.12% 🍏
InMemoryMqttSession.java 68.53% 🍏
MqttMessageOutFactory.java 66.88% 🍏
AbstractMqttPublishInMessageHandler.java 64.57% -18.9% 🍏
DefaultConnectionService.java 64.27% 🍏
Qos0MqttPublishInMessageHandler.java 51.28% -48.72% ❌
Qos2MqttPublishInMessageHandler.java 41.1% -55.21% ❌
PublishReleaseMqttInMessageHandler.java 40.79% -57.89% ❌
MqttSession.java 0% 🍏
PingResponseMqttInMessage.java 0% 🍏
PingRequestMqttInMessage.java 0% 🍏
PingResponseMqtt311OutMessage.java 0% 🍏
PingRequestMqtt311OutMessage.java 0% 🍏

@github-actions
Copy link

github-actions bot commented Nov 22, 2025

Overall Project 87.07% -2.25% 🍏
Files changed 78.16% 🍏

File Coverage
QoS.java 100% 🍏
PublishCompleteMqtt5OutMessage.java 100% 🍏
PublishReleaseMqtt311OutMessage.java 100% 🍏
DisconnectMqtt311OutMessage.java 100% 🍏
PublishAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
SubscribeMqtt311OutMessage.java 100% 🍏
PublishReleaseMqtt5OutMessage.java 100% 🍏
PublishCompleteMqtt311OutMessage.java 100% 🍏
PublishMqtt311OutMessage.java 100% 🍏
SubscribeAckMqtt311OutMessage.java 100% 🍏
PublishAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt5OutMessage.java 100% 🍏
PublishMqtt5OutMessage.java 100% 🍏
DisconnectMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt311OutMessage.java 100% 🍏
PublishReceiveMqttInMessageHandler.java 100% 🍏
PublishCompleteMqttInMessageHandler.java 100% 🍏
PublishAckMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
UnsubscribeMqttInMessageHandler.java 100% 🍏
TrackableMqttPublishInMessageHandler.java 100% 🍏
PublishAckReasonCode.java 100% 🍏
PublishReceivedReasonCode.java 100% 🍏
PublishCompletedReasonCode.java 100% 🍏
InMemoryActiveSubscriptions.java 100% 🍏
Publish.java 98.77% 🍏
PublishMqttInMessageHandler.java 97.62% -0.73% 🍏
SubscribeMqttInMessage.java 97.44% 🍏
PublishMqttInMessage.java 96.81% 🍏
InMemorySubscriptionService.java 96.59% 🍏
PublishReceivedMqttInMessage.java 96.34% 🍏
PublishCompleteMqttInMessage.java 96.34% 🍏
PublishAckMqttInMessage.java 96.1% 🍏
ConnectAckMqttInMessage.java 95.97% 🍏
AuthenticationMqtt5OutMessage.java 95.74% 🍏
PublishReleaseMqttInMessage.java 94.87% 🍏
UnsubscribeAckReasonCode.java 94.55% 🍏
DisconnectMqttInMessage.java 94.17% 🍏
ConnectAckReasonCode.java 93.21% 🍏
UnsubscribeAckMqttInMessage.java 92.31% 🍏
UnsubscribeMqttInMessage.java 92.31% 🍏
InMemoryTopicNameMapping.java 92.06% 🍏
AuthenticateReasonCode.java 92% 🍏
PublishReleaseReasonCode.java 92% 🍏
Mqtt5MessageOutFactory.java 91.67% 🍏
MqttMessageReader.java 90.14% 🍏
MqttBrokerSpringConfig.java 89.57% 🍏
MqttMessageType.java 88.39% 🍏
AuthenticationMqttInMessage.java 88.24% 🍏
ConnectMqttInMessage.java 87.69% 🍏
InMemoryMessageTacker.java 87.04% -12.96% 🍏
UnsubscribeAckMqtt311OutMessage.java 84.62% 🍏
DefaultPublishReceivingService.java 83.77% -11.52% ❌
SubscribeAckMqttInMessage.java 81.16% 🍏
ConnectInMqttInMessageHandler.java 80.58% -0.73% ❌
Qos1MqttPublishInMessageHandler.java 80.45% -19.55% 🍏
AbstractMqttPublishOutMessageHandler.java 77.78% 🍏
PublishRetryer.java 75% -25% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
InMemoryProcessingPublishes.java 73.23% -26.77% 🍏
ConnectMqtt311OutMessage.java 72.99% 🍏
InMemoryMqttSession.java 72.11% 🍏
Mqtt311MessageOutFactory.java 69.12% 🍏
MqttMessageOutFactory.java 66.88% -5.1% 🍏
Qos2MqttPublishInMessageHandler.java 65.64% -34.36% 🍏
AbstractMqttPublishInMessageHandler.java 64.57% -18.9% 🍏
DefaultConnectionService.java 64.27% 🍏
Qos0MqttPublishInMessageHandler.java 51.28% -48.72% ❌
PublishReleaseMqttInMessageHandler.java 40.79% -57.89% ❌
MqttSession.java 0% 🍏
PingResponseMqttInMessage.java 0% 🍏
PingRequestMqttInMessage.java 0% 🍏
PingResponseMqtt311OutMessage.java 0% 🍏
PingRequestMqtt311OutMessage.java 0% 🍏

crazyrokr
crazyrokr requested changes Nov 22, 2025
View reviewed changes
crazyrokr
crazyrokr requested changes Nov 22, 2025
View reviewed changes
crazyrokr
crazyrokr requested changes Nov 22, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 22, 2025

Overall Project 86.37% -2.25% 🍏
Files changed 78.33% 🍏

File Coverage
QoS.java 100% 🍏
PublishCompleteMqtt5OutMessage.java 100% 🍏
PublishReleaseMqtt311OutMessage.java 100% 🍏
DisconnectMqtt311OutMessage.java 100% 🍏
PublishAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
SubscribeMqtt311OutMessage.java 100% 🍏
PublishReleaseMqtt5OutMessage.java 100% 🍏
PublishCompleteMqtt311OutMessage.java 100% 🍏
PublishMqtt311OutMessage.java 100% 🍏
SubscribeAckMqtt311OutMessage.java 100% 🍏
PublishAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt5OutMessage.java 100% 🍏
PublishMqtt5OutMessage.java 100% 🍏
DisconnectMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt311OutMessage.java 100% 🍏
PublishReceiveMqttInMessageHandler.java 100% 🍏
PublishCompleteMqttInMessageHandler.java 100% 🍏
PublishAckMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
UnsubscribeMqttInMessageHandler.java 100% 🍏
TrackableMqttPublishInMessageHandler.java 100% 🍏
PublishAckReasonCode.java 100% 🍏
PublishReceivedReasonCode.java 100% 🍏
PublishCompletedReasonCode.java 100% 🍏
InMemoryActiveSubscriptions.java 100% 🍏
Publish.java 98.77% 🍏
PublishMqttInMessageHandler.java 97.62% -0.73% 🍏
SubscribeMqttInMessage.java 97.44% 🍏
PublishMqttInMessage.java 96.81% 🍏
InMemorySubscriptionService.java 96.59% 🍏
PublishReceivedMqttInMessage.java 96.34% 🍏
PublishCompleteMqttInMessage.java 96.34% 🍏
PublishAckMqttInMessage.java 96.1% 🍏
ConnectAckMqttInMessage.java 95.97% 🍏
AuthenticationMqtt5OutMessage.java 95.74% 🍏
PublishReleaseMqttInMessage.java 94.87% 🍏
UnsubscribeAckReasonCode.java 94.55% 🍏
DisconnectMqttInMessage.java 94.17% 🍏
ConnectAckReasonCode.java 93.21% 🍏
UnsubscribeAckMqttInMessage.java 92.31% 🍏
UnsubscribeMqttInMessage.java 92.31% 🍏
InMemoryTopicNameMapping.java 92.06% 🍏
AuthenticateReasonCode.java 92% 🍏
PublishReleaseReasonCode.java 92% 🍏
Mqtt5MessageOutFactory.java 91.67% 🍏
MqttMessageReader.java 90.14% 🍏
MqttBrokerSpringConfig.java 89.57% 🍏
MqttMessageType.java 88.39% 🍏
AuthenticationMqttInMessage.java 88.24% 🍏
ConnectMqttInMessage.java 87.69% 🍏
InMemoryMessageTacker.java 87.04% -12.96% 🍏
UnsubscribeAckMqtt311OutMessage.java 84.62% 🍏
DefaultPublishReceivingService.java 83.77% -11.52% ❌
SubscribeAckMqttInMessage.java 81.16% 🍏
ConnectInMqttInMessageHandler.java 80.58% -0.73% ❌
Qos1MqttPublishInMessageHandler.java 80.45% -19.55% 🍏
AbstractMqttPublishOutMessageHandler.java 77.78% 🍏
PublishRetryer.java 75% -25% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
InMemoryProcessingPublishes.java 73.23% -26.77% 🍏
ConnectMqtt311OutMessage.java 72.99% 🍏
Mqtt311MessageOutFactory.java 69.12% 🍏
InMemoryMqttSession.java 68.53% 🍏
MqttMessageOutFactory.java 66.88% -5.1% 🍏
Qos2MqttPublishInMessageHandler.java 65.64% -34.36% 🍏
AbstractMqttPublishInMessageHandler.java 64.57% -18.9% 🍏
DefaultConnectionService.java 64.27% 🍏
Qos0MqttPublishInMessageHandler.java 51.28% -48.72% ❌
PublishReleaseMqttInMessageHandler.java 40.79% -57.89% ❌
MqttSession.java 0% 🍏
PingResponseMqttInMessage.java 0% 🍏
PingRequestMqttInMessage.java 0% 🍏
PingResponseMqtt311OutMessage.java 0% 🍏
PingRequestMqtt311OutMessage.java 0% 🍏

@JavaSaBr JavaSaBr merged commit 9bf8458 into develop Nov 22, 2025
6 checks passed
@JavaSaBr JavaSaBr deleted the improve-publishing-part-2 branch November 22, 2025 16:27
@github-actions
Copy link

github-actions bot commented Nov 22, 2025

Overall Project 87.07% -2.25% 🍏
Files changed 78.33% 🍏

File Coverage
QoS.java 100% 🍏
PublishCompleteMqtt5OutMessage.java 100% 🍏
PublishReleaseMqtt311OutMessage.java 100% 🍏
DisconnectMqtt311OutMessage.java 100% 🍏
PublishAckMqtt5OutMessage.java 100% 🍏
UnsubscribeAckMqtt5OutMessage.java 100% 🍏
SubscribeMqtt311OutMessage.java 100% 🍏
PublishReleaseMqtt5OutMessage.java 100% 🍏
PublishCompleteMqtt311OutMessage.java 100% 🍏
PublishMqtt311OutMessage.java 100% 🍏
SubscribeAckMqtt311OutMessage.java 100% 🍏
PublishAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt5OutMessage.java 100% 🍏
PublishMqtt5OutMessage.java 100% 🍏
DisconnectMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt5OutMessage.java 100% 🍏
PublishReceivedMqtt311OutMessage.java 100% 🍏
PublishReceiveMqttInMessageHandler.java 100% 🍏
PublishCompleteMqttInMessageHandler.java 100% 🍏
PublishAckMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
UnsubscribeMqttInMessageHandler.java 100% 🍏
TrackableMqttPublishInMessageHandler.java 100% 🍏
PublishAckReasonCode.java 100% 🍏
PublishReceivedReasonCode.java 100% 🍏
PublishCompletedReasonCode.java 100% 🍏
InMemoryActiveSubscriptions.java 100% 🍏
Publish.java 98.77% 🍏
PublishMqttInMessageHandler.java 97.62% -0.73% 🍏
SubscribeMqttInMessage.java 97.44% 🍏
PublishMqttInMessage.java 96.81% 🍏
InMemorySubscriptionService.java 96.59% 🍏
PublishReceivedMqttInMessage.java 96.34% 🍏
PublishCompleteMqttInMessage.java 96.34% 🍏
PublishAckMqttInMessage.java 96.1% 🍏
ConnectAckMqttInMessage.java 95.97% 🍏
AuthenticationMqtt5OutMessage.java 95.74% 🍏
PublishReleaseMqttInMessage.java 94.87% 🍏
UnsubscribeAckReasonCode.java 94.55% 🍏
DisconnectMqttInMessage.java 94.17% 🍏
ConnectAckReasonCode.java 93.21% 🍏
UnsubscribeAckMqttInMessage.java 92.31% 🍏
UnsubscribeMqttInMessage.java 92.31% 🍏
InMemoryTopicNameMapping.java 92.06% 🍏
AuthenticateReasonCode.java 92% 🍏
PublishReleaseReasonCode.java 92% 🍏
Mqtt5MessageOutFactory.java 91.67% 🍏
MqttMessageReader.java 90.14% 🍏
MqttBrokerSpringConfig.java 89.57% 🍏
MqttMessageType.java 88.39% 🍏
AuthenticationMqttInMessage.java 88.24% 🍏
ConnectMqttInMessage.java 87.69% 🍏
InMemoryMessageTacker.java 87.04% -12.96% 🍏
UnsubscribeAckMqtt311OutMessage.java 84.62% 🍏
DefaultPublishReceivingService.java 83.77% -11.52% ❌
SubscribeAckMqttInMessage.java 81.16% 🍏
ConnectInMqttInMessageHandler.java 80.58% -0.73% ❌
Qos1MqttPublishInMessageHandler.java 80.45% -19.55% 🍏
AbstractMqttPublishOutMessageHandler.java 77.78% 🍏
PublishRetryer.java 75% -25% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
InMemoryProcessingPublishes.java 73.23% -26.77% 🍏
ConnectMqtt311OutMessage.java 72.99% 🍏
InMemoryMqttSession.java 72.11% 🍏
Mqtt311MessageOutFactory.java 69.12% 🍏
MqttMessageOutFactory.java 66.88% -5.1% 🍏
Qos2MqttPublishInMessageHandler.java 65.64% -34.36% 🍏
AbstractMqttPublishInMessageHandler.java 64.57% -18.9% 🍏
DefaultConnectionService.java 64.27% 🍏
Qos0MqttPublishInMessageHandler.java 51.28% -48.72% ❌
PublishReleaseMqttInMessageHandler.java 40.79% -57.89% ❌
MqttSession.java 0% 🍏
PingResponseMqttInMessage.java 0% 🍏
PingRequestMqttInMessage.java 0% 🍏
PingResponseMqtt311OutMessage.java 0% 🍏
PingRequestMqtt311OutMessage.java 0% 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazyrokr crazyrokr crazyrokr approved these changes

Assignees

@JavaSaBr JavaSaBr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JavaSaBr @crazyrokr