Conversation
- Fix null concatenation deprecation in setUserAgent (PHP 8.1+) - Fix MSIE exclusion pattern missing * quantifier - Reset matches at top of isCrawler() for reliable state - Add preg error handling in isCrawler() - Make compileRegex() protected (internal API) - Add return type declarations to all methods - Add parameter type hints throughout - Use setUp() in tests, fix property visibility/naming - Fix typo in test method name (persit -> persist) - Optimize collision test from O(n²) to O(n²/2) - Add tests for regex validity and stored agent immutability
Keeps the bug fixes and deprecation fix in isCrawler()/setUserAgent() and the MSIE exclusion pattern fix, but drops the param/return type declarations and the compileRegex() visibility change so this can ship as a patch release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JayBizzle
changed the title
Forces preg_match to return PREG_BACKTRACK_LIMIT_ERROR by setting pcre.backtrack_limit to 1, covering the previously untested error path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch-safe bug fixes and test improvements. No public API or signature changes, suitable for a point release.
Bug fixes
setUserAgent()(PHP 8.1+)MSIEexclusion pattern missing*quantifier$matchesat top ofisCrawler()so stale matches don't leak across callspreg_match/preg_replaceerror handling inisCrawler()$httpHeaders/$userAgentparameters tonullonsetHttpHeaders()/setUserAgent()for ergonomic parity with the constructorTest improvements
setUp()to instantiateCrawlerDetectonce per test$crawlerDetectand make itprotectedpersit->persist)isCrawler($ua)does not mutate the stored user agentDeferred to next major
Type declarations, return types and the
compileRegex()visibility change have been dropped from this PR — they'll be bundled into the next major release.