Implement save upload, extend __request method to allow for multiparts#3
Merged
Merged
Conversation
Jayy001
requested changes
Sep 16, 2024
Owner
Jayy001
left a comment
Jayy001
left a comment
There was a problem hiding this comment.
Just some minor nitpicks - apart from that, looks great - thank you!
Owner
|
Perfect, thanks very much - I'll merge this and get the downloading sorted too |
Contributor
Author
Awesome, thanks for the effort! |
Jayy001
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should probably be tested a bit further before merging.
Note that I exchanged
auth=self.auth if self.auth else Noneto
auth=self.authas that should also work (?)
If there is anything to change, feel free to keep me updated