device: add rm1 Prototype

[celie56]

#151

Summary by CodeRabbit

• New Features
  • Added support for recognizing "Remarkable Prototype 1" as a valid device type variant.

[coderabbitai]

Walkthrough

The HardwareType.parse() method is updated to accept an additional device type string alias, "remarkable prototype 1", which maps to the RM1 hardware type. No other logic or API changes are introduced.

Changes

Cohort / File(s)	Change Summary
HardwareType parser expansion codexctl/device.py	Updated HardwareType.parse() to recognize "remarkable prototype 1" as an accepted input token that maps to RM1 hardware type. Expands the set of aliases checked in the RM1 parsing branch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file modified with minimal, additive change (one additional string literal)
• Existing method signature and overall logic flow unchanged
• Low risk: purely expanding an accepted-values set with no conditional or structural modifications

Possibly related PRs

• Consolidate device type logic & add --hardware option to codexctl list #141: Directly extends HardwareType.parse() to accept "remarkable prototype 1" alias mapping to RM1, modifying the same method logic
• Fix device type parsing #149: Also modifies codexctl/device.py's HardwareType.parse() to adjust accepted device-type string literals and aliases

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'device: add rm1 Prototype' clearly and specifically describes the main change: adding support for the RM1 Prototype device type to the device module.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32abb05 and 4d8acd6.

📒 Files selected for processing (1)

• codexctl/device.py (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-09-10T16:37:10.452Z

Learnt from: Eeems
Repo: Jayy001/codexctl PR: 140
File: codexctl/__init__.py:54-55
Timestamp: 2025-09-10T16:37:10.452Z
Learning: In codexctl/__init__.py, the UpdateManager methods (get_latest_version, get_toltec_version, download_version) all expect HardwareType enum parameters, not string parameters.

Applied to files:

• codexctl/device.py

🔇 Additional comments (1)

codexctl/device.py (1)

30-30: LGTM! The new alias follows the existing pattern correctly.

The addition of "remarkable prototype 1" as an RM1 device type alias is implemented consistently with the existing device type recognition logic.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}