Look for 'Done' in stderr when exit code is non-zero#107
Merged
alanhamlett merged 3 commits intoJazzCore:masterfrom Oct 22, 2018
Merged
Look for 'Done' in stderr when exit code is non-zero#107alanhamlett merged 3 commits intoJazzCore:masterfrom
alanhamlett merged 3 commits intoJazzCore:masterfrom
Conversation
Sometimes wkhtmltopdf will exit with non-zero even if the generation is successful.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes
wkhtmltopdfwill exit with non-zero even if it finishes the PDF generation.In this case it will contain a 'Done' in its stderr.
We should still use the generated pdf in this case.