refactor: deduplicate NAV layout setup into shared helper#372
Merged
Conversation
…elper Co-authored-by: tschm <2046079+tschm@users.noreply.github.com> Agent-Logs-Url: https://github.com/tschm/jquantstats/sessions/225c5ce3-6b18-4bf2-8ff0-df0f3ae0da77
Copilot
AI
changed the title
[WIP] Fix duplicated code in analytics plots
refactor: deduplicate NAV layout setup into shared helper
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lagged_performance_plotandsmoothed_holdings_performance_plotcontained identical 27-line Plotly layout blocks differing only by title string.Changes
_apply_nav_layoutstatic method — encapsulates the sharedupdate_layout/update_xaxes/update_yaxes/log_scalelogic, parameterised bytitleandlog_scaleOriginal prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.