Skip to content

[WIP] Stabilize date_col convention by making it a class-level attribute#400

Merged
tschm merged 3 commits intomainfrom
copilot/stabilize-date-col-convention
Mar 23, 2026
Merged

[WIP] Stabilize date_col convention by making it a class-level attribute#400
tschm merged 3 commits intomainfrom
copilot/stabilize-date-col-convention

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 23, 2026

  • Explore repository and understand current date_col usage
  • Run baseline tests (344 pass)
  • Update _data.py: replace date_col property with a proper dataclass field date_col: str = "Date", and thread date_col=self.date_col through all internal Data() construction calls
  • Update api.py: change build_data() default to Data.date_col and pass date_col=date_col to Data(...) constructor
  • Update _stats.py: fix all self.data.date_col usages (was list[str], now str), and pass date_col=self.data.date_col when constructing Data objects internally
  • Update test in test_data.py: date_col now returns str, not list[str]
  • Run tests and verify all pass
  • Code review + CodeQL check
Original prompt

This section details on the original issue you should resolve

<issue_title>Stabilize date_col convention — Consider making date_col a class-level attribute on Data instead of threading it through function parameters</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@tschm tschm marked this pull request as ready for review March 23, 2026 10:57
@tschm tschm merged commit dc8d02c into main Mar 23, 2026
21 checks passed
@tschm tschm deleted the copilot/stabilize-date-col-convention branch March 23, 2026 11:03
Copilot AI requested a review from tschm March 23, 2026 11:03
Copilot stopped work on behalf of tschm due to an error March 23, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize date_col convention — Consider making date_col a class-level attribute on Data instead of threading it through function parameters

2 participants