Establish GitContext dataclass for injectable git context#415
Merged
Conversation
Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Establish GitContext dataclass for consistent git invocation
Establish GitContext dataclass for injectable git context
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_diffwas the only git-invoking function in_sync_helpers.pythat resolved its own executable viaget_git_executable()internally, making binary injection in tests impossible and breaking consistency with every other git-calling function in the module.Changes
GitContextdataclass (rhiza.models._git_utils) — bundlesexecutable: strandenv: dict[str, str]; exposes aGitContext.default()classmethod that mirrors the setup previously scattered across callersrhiza.models— available as a first-class public API symbol_get_diffnow acceptsgit_ctx: GitContext— no longer resolves the binary itself; consistent with all other helpers in the module_sync_diffpropagatesgit_ctx: GitContext— threading the context down to_get_diff_merge_with_base— constructs aGitContextinline from its existinggit_executable/git_envparams; no signature change requiredsync.py— passesGitContextto_sync_diffTests
TestGitContextadded totest_subprocess_utils.pycovering direct construction, default env values, anddefault()classmethod behaviour_get_diffand_sync_diffcall sites intest_sync.pyupdated to pass an explicitGitContextOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.