Skip to content

Added primitive data type check in cleanValue util function#3323

Open
mnpreetkaur wants to merge 2 commits intoJedWatson:masterfrom
mnpreetkaur:fix-3048
Open

Added primitive data type check in cleanValue util function#3323
mnpreetkaur wants to merge 2 commits intoJedWatson:masterfrom
mnpreetkaur:fix-3048

Conversation

@mnpreetkaur
Copy link
Copy Markdown

Closes #3048

@mnpreetkaur
Copy link
Copy Markdown
Author

Added the empty string condition as on selecting an empty string Select box should reset to default placeholder.

@bladey bladey added enhancement pr/needs-review PRs that need to be reviewed to determine outcome labels Jun 4, 2020
@bladey bladey added pr/enhancement PRs that are specifically enhancing the project and removed category/enhancement labels Jun 24, 2020
@ebonow
Copy link
Copy Markdown
Collaborator

ebonow commented Jan 16, 2021

Case for PR:
When using an array of options that are of type String or Number and using getOptionValue and getOptionLabel, the result of the onChange value returns no value.

Since the select can render these options and that this is not an issue when isMulti, it should be expected that the value should be the same value as the selected option when isMulti is false.

Case against PR:
#4058 (comment)

Nice work. The bad news is I don't think the collaborator would accept this change after I checked the early related issues and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/enhancement PRs that are specifically enhancing the project pr/needs-review PRs that need to be reviewed to determine outcome

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't display the selected option (Single Select & getOption)

3 participants