Skip to content

#4146 Add menu position recalculation after async data is loaded#4542

Open
Wunsz wants to merge 3 commits intoJedWatson:masterfrom
Wunsz:master
Open

#4146 Add menu position recalculation after async data is loaded#4542
Wunsz wants to merge 3 commits intoJedWatson:masterfrom
Wunsz:master

Conversation

@Wunsz
Copy link
Copy Markdown

@Wunsz Wunsz commented Apr 16, 2021

Fixes #4146 by calling getPlacement function in MenuPlacer once async call is finished (both promise and callback approach).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 16, 2021

⚠️ No Changeset found

Latest commit: f4f16d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Apr 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f4f16d7:

Sandbox Source
react-codesandboxer-example Configuration

@ebonow
Copy link
Copy Markdown
Collaborator

ebonow commented Apr 21, 2021

Greetings @Wunsz ,

This looks interesting and thank you for contributing. We are in the process of replacing Flow with TypeScript so to avoid complexities, we are pausing on merging PR's. Once the TypeScript conversion and any other potential breaking changes have been pushed in the major release, we will take a look at this PR along with any other work associated with Menu positioning, sizing, and event handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async menu list height remains unchanged after options loaded

2 participants