Cleaned up custom :menuRenderer example to use react-virtualized-select HOC#862
Merged
JedWatson merged 3 commits intoJedWatson:masterfrom Apr 6, 2016
Merged
Cleaned up custom :menuRenderer example to use react-virtualized-select HOC#862JedWatson merged 3 commits intoJedWatson:masterfrom
JedWatson merged 3 commits intoJedWatson:masterfrom
Conversation
Contributor
|
|
Collaborator
Author
|
Hi @omgaz. I'm not sure I understand. Are you suggesting I change from tabs to spaces? I attempted to follow the default used in the other files. |
Contributor
|
Hey, sorry my bad mis-read the contrib. Statement retracted! LGTM 🍥 |
Owner
|
Thanks @bvaughn! looks great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A live version of this PR can be seen here: http://bvaughn.github.io/react-select/
With PR #859 merged and v1.0.0-beta12 released, I released a new HOC-
react-virtualized-select- so that I can take on the ownership of maintaining an interface between react-select and react-virtualized. A demo of the HOC can be seen here: http://bvaughn.github.io/react-virtualized-select/This PR updates the example to use that HOC. (I think it's the simplest way to integrate the 2 libraries so it seems like the way we should show in a demo.)