Fix searchingText bug#942
Merged
JedWatson merged 1 commit intoJedWatson:masterfrom May 7, 2016
tonydecat:async-loading-bug
Merged
Fix searchingText bug#942JedWatson merged 1 commit intoJedWatson:masterfrom tonydecat:async-loading-bug
JedWatson merged 1 commit intoJedWatson:masterfrom
tonydecat:async-loading-bug
Conversation
…arch did not match any previous results
Owner
|
That's clear, thanks @tonydecat! |
|
hi. Is the package.json updated to this commit? |
Contributor
Author
|
@JuanCrg90 If you're using npm I believe you'll have to wait for the next release (probably v1.0.0-beta14) to get this fix. Perhaps @JedWatson can confirm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Async component with a large number of options, it's possible that refining the search input doesn't match any previously loaded results, but may match new results returned by the server. There was a bug in the text that's displayed
For example, let's say a search of "a" asynchronously returned options
The user then refines their search to "ab"
This shows a loading spinner and no options, while it makes an asynchronous request with the new search query.
There was a bug where "No results found" was displayed under the search input while waiting for a response, instead of "Searching...". This PR fixes that bug.
I'd be happy to clarify what the bug is if it's still not clear to anyone.
(#941 or similar should get merged first since that fixes a more general bug with async)