Match Wrap container to comparable New container#142
Open
rflandau wants to merge 2 commits intoJeffail:masterfrom
Open
Match Wrap container to comparable New container#142rflandau wants to merge 2 commits intoJeffail:masterfrom
rflandau wants to merge 2 commits intoJeffail:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#141
This change encapsulates data given to
.Wrap()in a map[string]interface{}, similar to the structure a container created by.New().Marshalling and unmarshalling is probably not the most efficient way to do this and there may be some value in adding type assertions via reflection, but I am not one to bring the baggage of reflect to someone else's project.