Merged
Conversation
…perf, making sure queued data is sent out before exit
… results for easy consumption
…e leak, in reassembler several shutdown leaks
Transferred scripts/zero_to_hero directory with all documentation, examples, and utilities from the zero_to_hero branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit resolves all blocking and non-blocking issues identified in the PR #159 code review. Blocking fixes: - Remove hardcoded /global/homes/y/yak/ paths from SLURM scripts (perlmutter_slurm.sh, perlmutter_multi_slurm.sh) and require E2SAR_SCRIPTS_DIR environment variable instead - Fix reservation validity check in minimal_reserve.sh to use instance URI instead of admin URI, ensuring stale sessions are properly detected Configuration improvements: - Add LB_NAME variable and --lbname option to minimal_reserve.sh for configurable reservation names (replaces hardcoded "yk_test") - Make container image configurable via E2SAR_IMAGE variable in minimal_reserve.sh and minimal_free.sh Security and logging: - Redact EJFAT_URI tokens in output logs for minimal_sender.sh, minimal_receiver.sh, and minimal_free.sh - Remove duplicate END_TIME/EXIT_CODE log entries in minimal_sender.sh and minimal_receiver.sh (trap handler already logs these) Documentation: - Update CLAUDE.md with E2SAR_SCRIPTS_DIR requirement for SLURM scripts - Document LB_NAME environment variable and --lbname option - Add prerequisites section for SLURM batch processing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add cleanup traps to prevent orphaned LB reservations on job cancellation, replace unsafe source commands with grep-based extraction to prevent code execution, and hide authentication tokens from process listings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes remaining security vulnerabilities in minimal_reserve.sh and minimal_free.sh: - Replace unsafe source command with grep-based URI extraction in minimal_reserve.sh - Use --env instead of -e for EJFAT_URI to prevent token exposure in process listings - Properly handle temporary URI swapping for validation while preserving admin URI These changes complete the security hardening started in commit 8a314d4, ensuring all EJFAT_URI tokens are safely passed through environment variables rather than command-line arguments visible in ps output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Transferred scripts/zero_to_hero directory with all documentation, examples, and utilities from the zero_to_hero branch. This documentation shows how to run e2sar_perf and other tools using Perlmutter.
Add workflow dispatch input for PR number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-v/--novalidateflag in lbadm