Skip to content

Conversation

@cissieAB
Copy link
Collaborator

@cissieAB cissieAB commented Mar 20, 2024

Build&test process

$ cd packetblast
$ meson build
$ ninja -C build
...
[2/2] Linking target packetblast.cpython-312-darwin.so

$ python3 python/test_bindings.py
ioctl says MTU = 1280
1280

@cissieAB cissieAB requested a review from ibaldin March 20, 2024 05:38
@cissieAB cissieAB self-assigned this Mar 20, 2024
@cissieAB cissieAB added the good first issue Good for newcomers label Mar 20, 2024
@ibaldin
Copy link
Collaborator

ibaldin commented Mar 20, 2024

This has a lot of old ET code - do we really want to import this? What is the end goal for this code?

I am a bit delinquent in building up the header structure I wanted to do (I've been doing C++ review ;-) )

@cissieAB
Copy link
Collaborator Author

cissieAB commented Mar 21, 2024

This has a lot of old ET code - do we really want to import this? What is the end goal for this code?

I am a bit delinquent in building up the header structure I wanted to do (I've been doing C++ review ;-) )

Hi, I keep three header files "ejfat_packetize.hpp", "ejfat_network.hpp" and "ejfat_assemble_ersap.hpp" and delete all the others. I feel some helper functions in these header files would be useful.

This PR is trying to test the compiling, building and Python binding system of meson+ninja+pybind11 is working 😄

- Create `packetblast` folder to add some existing ejfat C++ code;
- Add meson.build file to build some C++ code into a Python module with `pybind11`;
- `ninja -C build` passed. Python test code under `packetblast/python` is working.
@cissieAB cissieAB closed this Mar 21, 2024
@cissieAB cissieAB deleted the cissie_ejfat branch March 21, 2024 17:47
yakyakyak added a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants