Skip to content

fix(ci): update actions and dependencies#66

Merged
dglazier merged 10 commits intoJeffersonLab:masterfrom
c-dilks:ci-fixes
Feb 12, 2024
Merged

fix(ci): update actions and dependencies#66
dglazier merged 10 commits intoJeffersonLab:masterfrom
c-dilks:ci-fixes

Conversation

@c-dilks
Copy link
Copy Markdown
Member

@c-dilks c-dilks commented Feb 8, 2024

  • update actions (for Node)
  • use PyPI to install scons version compatible with Python2 and CCDB

@dglazier
Copy link
Copy Markdown
Collaborator

dglazier commented Feb 8, 2024

Yeah, after updating the action for hipo, I couldn't get it past ccdb. IT may be best just to delete the action.

@c-dilks c-dilks marked this pull request as draft February 8, 2024 17:03
@c-dilks
Copy link
Copy Markdown
Member Author

c-dilks commented Feb 8, 2024

I suspect the container version jump may be the culprit:

-        version: [6.22.02-ubuntu20.04]
+        version: [6.28.12-ubuntu22.04]

scons isn't working on master. Do you need CCDB for CI tests?

@c-dilks
Copy link
Copy Markdown
Member Author

c-dilks commented Feb 8, 2024

I see now why you were forcing this step to use python2...

@c-dilks
Copy link
Copy Markdown
Member Author

c-dilks commented Feb 8, 2024

Finally working!

@c-dilks c-dilks marked this pull request as ready for review February 8, 2024 17:59
@dglazier dglazier merged commit cab813e into JeffersonLab:master Feb 12, 2024
@c-dilks c-dilks deleted the ci-fixes branch February 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants