Skip to content

feat: keep track of field types during initialization instead of checking later#1252

Open
baltzell wants to merge 2 commits intodevelopmentfrom
profiling-mag4
Open

feat: keep track of field types during initialization instead of checking later#1252
baltzell wants to merge 2 commits intodevelopmentfrom
profiling-mag4

Conversation

@baltzell
Copy link
Copy Markdown
Collaborator

@baltzell baltzell commented May 8, 2026

MagneticFields.hasActiveTorus/Solenoid are hot spots.

This superseded #1249, which only optimized for our most common use case.

@baltzell baltzell changed the title keep track instead of calculating later feat: keep track instead of calculating later May 8, 2026
@baltzell baltzell requested a review from raffaelladevita May 8, 2026 22:17
@baltzell baltzell marked this pull request as ready for review May 8, 2026 22:17
@baltzell baltzell requested a review from heddle as a code owner May 8, 2026 22:17
@baltzell baltzell marked this pull request as draft May 8, 2026 22:28
@baltzell baltzell closed this May 8, 2026
@baltzell baltzell reopened this May 8, 2026
@baltzell baltzell added the speed label May 9, 2026
@baltzell baltzell changed the title feat: keep track instead of calculating later feat: keep track of field types instead of calculating later May 9, 2026
@baltzell baltzell changed the title feat: keep track of field types instead of calculating later feat: keep track of field types instead of checking later May 9, 2026
@baltzell baltzell changed the title feat: keep track of field types instead of checking later feat: keep track of field types during initialization instead of checking later May 9, 2026
@baltzell baltzell marked this pull request as ready for review May 9, 2026 02:09
@baltzell baltzell requested a review from heddle May 9, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant