Skip to content

Issue 173 helicity decoder #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baltzell merged 5 commits into from
Jan 30, 2024
Merged

Issue 173 helicity decoder #174

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98794f4
Modifications to allow decoding of Helicity Decoder EVIO both with 40…
mholtrop Jan 22, 2024
7c4cb26
Fixed issue with Java not having unsigned int, and reading the timest…
mholtrop Jan 22, 2024
fa4b9eb
As Raffaella pointed out, i_data_offset needs to be incremented by 1.
mholtrop Jan 24, 2024
326700b
Merge branch 'development' into issue_173_helicity_decoder
mholtrop Jan 24, 2024
ec713d4
Merge branch 'development' into issue_173_helicity_decoder
baltzell Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 49 additions & 22 deletions common-tools/clas-detector/src/main/java/org/jlab/detector/decode/CodaEventDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,34 +1049,61 @@ public HelicityDecoderData getDataEntries_HelicityDecoder(EvioDataEvent event){

long[] longData = ByteDataTransformer.toLongArray(node.getStructureBuffer(true));
int[] intData = ByteDataTransformer.toIntArray(node.getStructureBuffer(true));
long timeStamp = longData[2]&0x0000ffffffffffffL;

int tsettle = DataUtils.getInteger(intData[16], 0, 0) > 0 ? 1 : -1;
int pattern = DataUtils.getInteger(intData[16], 1, 1) > 0 ? 1 : -1;
int pair = DataUtils.getInteger(intData[16], 2, 2) > 0 ? 1 : -1;
int helicity = DataUtils.getInteger(intData[16], 3, 3) > 0 ? 1 : -1;
int start = DataUtils.getInteger(intData[16], 4, 4) > 0 ? 1 : -1;
int polarity = DataUtils.getInteger(intData[16], 5, 5) > 0 ? 1 : -1;
int count = DataUtils.getInteger(intData[16], 8, 11);

// When there are multiple HelicityDecoder banks in an event, there is a BLKHDR work in the data,
// and when there is one HelicityDecoder bank in an event, it is not there. So we need to
// detect where the trigger time word is.
int i_data_offset = 2;
int i_data_length = intData.length;
while(i_data_offset<intData.length){
// The following idiotic construction is needed because Java doesn't have unsigned ints,
// and a right shift on a negative int results in a negative number.
int int_test_value = (int) (( ((long)intData[i_data_offset]) & 0x00000000ffffffffL ) >> 27);
if(int_test_value == 0x13) break;
i_data_offset++;
} // find the trigger time word.
if(i_data_offset>=intData.length){
System.err.println("ERROR: HelicityDecoder data is corrupted. Trigger time word not found.");
return null;
}
long timeStamp = (intData[i_data_offset]&0x00ffffff) + (((long)(intData[i_data_offset+1]&0x00ffffffL))<<24);
i_data_offset+=2; // Next word should be "DECODER DATA", with 0x18 in the top 5 bits.
if(((int) (( ((long)intData[i_data_offset]) & 0x00000000ffffffffL ) >> 27)) != 0x18){
System.err.println("ERROR: HelicityDecoder data is corrupted. DECODER BANK not found.");
return null;
}
int num_data_words = intData[i_data_offset]&0x07ffffff;
if(num_data_words < 14){
System.err.println("ERROR: HelicityDecoder data is corrupted. Not enough data words.");
return null;
}
i_data_offset ++; // Point to the first word in the data block.
int tsettle = DataUtils.getInteger(intData[i_data_offset+9], 0, 0) > 0 ? 1 : -1;
Copy link
Collaborator

@raffaelladevita raffaelladevita Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i_data_offset should be incremented by 1 before this line

Copy link
Collaborator Author

@mholtrop mholtrop Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that Raffaella. You are quite correct. An update was pushed.
I still need to do a detailed analysis of the helicity. I am not quite understanding what Nathan is referring to.

Copy link
Collaborator

@baltzell baltzell Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm referring to the most critical data in the HEL::decoder bank, those "Array" variables that contain the helicity state sequences seen so far. Previously they were consistent with good sequences, and, in this PR prior to Raffaella's recent suggestion, were not.

int pattern = DataUtils.getInteger(intData[i_data_offset+9], 1, 1) > 0 ? 1 : -1;
int pair = DataUtils.getInteger(intData[i_data_offset+9], 2, 2) > 0 ? 1 : -1;
int helicity = DataUtils.getInteger(intData[i_data_offset+9], 3, 3) > 0 ? 1 : -1;
int start = DataUtils.getInteger(intData[i_data_offset+9], 4, 4) > 0 ? 1 : -1;
int polarity = DataUtils.getInteger(intData[i_data_offset+9], 5, 5) > 0 ? 1 : -1;
int count = DataUtils.getInteger(intData[i_data_offset+9], 8, 11);
data = new HelicityDecoderData((byte) helicity, (byte) pair, (byte) pattern);
data.setTimestamp(timeStamp);
data.setHelicitySeed(intData[7]);
data.setNTStableRisingEdge(intData[8]);
data.setNTStableFallingEdge(intData[9]);
data.setNPattern(intData[10]);
data.setNPair(intData[11]);
data.setTStableStart(intData[12]);
data.setTStableEnd(intData[13]);
data.setTStableTime(intData[14]);
data.setTSettleTime(intData[15]);
data.setHelicitySeed(intData[i_data_offset]);
data.setNTStableRisingEdge(intData[i_data_offset+1]);
data.setNTStableFallingEdge(intData[i_data_offset+2]);
data.setNPattern(intData[i_data_offset+3]);
data.setNPair(intData[i_data_offset+4]);
data.setTStableStart(intData[i_data_offset+5]);
data.setTStableEnd(intData[i_data_offset+6]);
data.setTStableTime(intData[i_data_offset+7]);
data.setTSettleTime(intData[i_data_offset+8]);
data.setTSettle((byte) tsettle);
data.setHelicityPattern((byte) start);
data.setPolarity((byte) polarity);
data.setPatternPhaseCount((byte) count);
data.setPatternWindows(intData[17]);
data.setPairWindows(intData[18]);
data.setHelicityWindows(intData[19]);
data.setHelicityPatternWindows(intData[20]);
data.setPatternWindows(intData[i_data_offset+10]);
data.setPairWindows(intData[i_data_offset+11]);
data.setHelicityWindows(intData[i_data_offset+12]);
data.setHelicityPatternWindows(intData[i_data_offset+13]);
}
}
}
Expand Down