Issue 173 helicity decoder #174
Conversation
… banks in a single event and with 1 bank every event.
|
Looks like I accidentally posted this on the corresponding issue instead of this PR ... Running this on one of the few files I'd been using for testing (run 19349, file 40), looks to me like the bit sequences are now off in the HEL::decoder bank. For example: Previously they were all consitent with good quartet patterns, assuming signal inversion (which has now been confirmed). |
| System.err.println("ERROR: HelicityDecoder data is corrupted. Not enough data words."); | ||
| return null; | ||
| } | ||
| int tsettle = DataUtils.getInteger(intData[i_data_offset+9], 0, 0) > 0 ? 1 : -1; |
There was a problem hiding this comment.
i_data_offset should be incremented by 1 before this line
There was a problem hiding this comment.
Thank you for catching that Raffaella. You are quite correct. An update was pushed.
I still need to do a detailed analysis of the helicity. I am not quite understanding what Nathan is referring to.
There was a problem hiding this comment.
I'm referring to the most critical data in the HEL::decoder bank, those "Array" variables that contain the helicity state sequences seen so far. Previously they were consistent with good sequences, and, in this PR prior to Raffaella's recent suggestion, were not.
|
The resulting HEL::decoder bank looks good again regarding helicity bit sequences. |
This code allows semi-correct () decoding for the "old" style data, were 40 helicity decoder banks show up in one event, and the correct type data where this bank is in each event.
() Semi-correct because it will only parse one of those 40 helicity decoder entries.
The code was tested on run 19400 file 40, which has helicity decoder data every event, and 19407 which has 40 in one event and no crash or error is observer.
Please double check the parsing of the timestamp information.