Revised the name of the hit bank in AHDCengine.java#225
Closed
efuchey wants to merge 10 commits intoJeffersonLab:developmentfrom
Closed
Revised the name of the hit bank in AHDCengine.java#225efuchey wants to merge 10 commits intoJeffersonLab:developmentfrom
efuchey wants to merge 10 commits intoJeffersonLab:developmentfrom
Conversation
It should have been AHDC::adc (since corresponding HitReader also uses this bank), it was AHDC::tdc.
Collaborator
|
Please merge ASAP |
Collaborator
|
Sounds like this change is supposed to make it consistent with what's coming out of GEMC currently? |
Collaborator
|
There are related PRs: |
Member
|
Ignore the deployment errors (CI issue, fixed upstream). |
Member
|
It doesn't look like this PR changes anything anymore, or perhaps your proposed changes are already upstream. Closing, but please re-open if you still need this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised the name of the hit bank in AHDCengine.java