Upgrade FD tracking #250
Merged
Upgrade FD tracking #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate dc package to apply new KF package
…to single or double
raffaelladevita
requested changes
Apr 9, 2024
Collaborator
raffaelladevita
left a comment
raffaelladevita
left a comment
There was a problem hiding this comment.
Most of the comments from #107 review have been addressed. I suggest adding a few more comments in the code as reminders of changes that should be done in the future.
common-tools/clas-tracking/src/main/java/org/jlab/clas/tracking/kalmanfilter/AMeasVecs.java
Show resolved
Hide resolved
common-tools/clas-tracking/src/main/java/org/jlab/clas/tracking/kalmanfilter/AMeasVecs.java
Outdated
Show resolved
Hide resolved
common-tools/clas-tracking/src/main/java/org/jlab/clas/tracking/kalmanfilter/AStateVecs.java
Outdated
Show resolved
Hide resolved
raffaelladevita
approved these changes
Apr 10, 2024
Collaborator
raffaelladevita
left a comment
raffaelladevita
left a comment
There was a problem hiding this comment.
Run a quick test reconstructing one file from run 5038 (RG-A Fall 18): Clara benchmarks using 64 threads on clara1603 and W spectrum included below in comparison to development
- Development:
- this branch:
Member
|
Triggered a |
Member
All good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#107 (#107) is for updates of both DC-only and DC-uRWell tracking.
As discussed with the software group, updates for DC-only and DC-uRWell tracking should be separated.
This branch removes all updates for DC-uRWell tracking so as to remain updates for DC-only tracking.
In the PR, the main updates for forward tracking can be summarized as follows:
Here are links for details of updates: talk 1 and talk 2.
Here are links link for validation: talk1 and talk2