Synching ALERT fork with main branch #378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have been AHDC::adc (since corresponding HitReader also uses this bank), it was AHDC::tdc.
(and stop changing wire number internally to start from zero) (this requires removing a manual +1 offset for wire number in a perl script in GEMC)
Iss272 alert indexing
get latest changes
Fix of a merge error after commit f10c09e
PreCluster pairing routine in AHDC ClusterFinder
…r-layer list of hits in AHDC PreCluster Modified the hardcoded lookup superlayer indices to obtain the geometry parameters to calculate x, y.
Modifications for debugging/validation of index convention change.
mpaolone
dismissed
baltzell’s stale review
The merge-base changed after approval.
baltzell
approved these changes
Jan 2, 2025
baltzell
approved these changes
Jan 2, 2025
baltzell
approved these changes
Jan 2, 2025
baltzell
approved these changes
Jan 2, 2025
baltzell
previously approved these changes
Jan 2, 2025
mpaolone
dismissed
baltzell’s stale review
The merge-base changed after approval.
raffaelladevita
approved these changes
Jan 2, 2025
Collaborator
raffaelladevita
left a comment
raffaelladevita
left a comment
There was a problem hiding this comment.
All pending changes have been transformed into issues
baltzell
approved these changes
Jan 2, 2025
baltzell
approved these changes
Jan 2, 2025
raffaelladevita
previously approved these changes
Jan 2, 2025
baltzell
previously approved these changes
Jan 2, 2025
mpaolone
dismissed stale reviews from baltzell and raffaelladevita
The merge-base changed after approval.
baltzell
previously approved these changes
Jan 2, 2025
mpaolone
dismissed
baltzell’s stale review
The merge-base changed after approval.
Collaborator
|
closing just to workaround github bug ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.