-
Notifications
You must be signed in to change notification settings - Fork 26
Alert engine for combined ATOF/AHDC reconstruction #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modified: ahdc/Cluster/ClusterFinder.java modified: ahdc/Distance/Distance.java modified: ahdc/HelixFit/HelixFitJava.java modified: ahdc/HelixFit/HelixFitObject.java modified: ahdc/PreCluster/PreCluster.java modified: service/AHDCEngine.java
modified: reconstruction/alert/src/main/java/org/jlab/rec/service/ALERTEngine.java
…ERTEngine.java modified: reconstruction/alert/src/main/java/org/jlab/rec/service/ATOFEngine.java
|
I suspect people might prefer to leave the old ones intact for now, maybe just suffix their names to designate they're the old ones. |
Not sure what you are saying? The old Engines are still there and used. The only change is I moved the Track projections into ALERTEngine where it is more appropriate. |
|
Yes, the old ones' names are still there and used, but their functionality is changed, and their previous functionality is no longer easily accessible. In the short term, it'd probably be better to keep their functionality easily accessible, and one easy way to do that is by renaming those old engine classes with a suffix, rather than replacing them, simultaneously designating that they'll be going away in the near future. |
|
I still don't understand. All I have done is add a new engine called ALERTEngine. None of the functionality changed. I can move the projection back to ATOFEngine but the next PR will move it out of there.... |
modified: service/ALERTEngine.java modified: service/ATOFEngine.java
modified: service/ALERTEngine.java
…e/Component.java
modified: ../../../../../../../../common-tools/clas-geometry/src/main/java/org/jlab/geom/base/Component.java renamed: ../rec/service/AHDCEngine.java -> ahdc/AHDCEngine.java renamed: ../rec/service/ALERTEngine.java -> alert/ALERTEngine.java renamed: ../rec/service/ATOFEngine.java -> atof/ATOFEngine.java
* Moved ATOF Track projections to ALERTEngine since it will need a track * Added many todo comments in code. * Cleaned up various if statements for clarity. * moved services to proper project directory structure that is picked up by javadocs --------- Co-authored-by: Whitney Armstrong <warmstrong@anl.gov>
* Moved ATOF Track projections to ALERTEngine since it will need a track * Added many todo comments in code. * Cleaned up various if statements for clarity. * moved services to proper project directory structure that is picked up by javadocs --------- Co-authored-by: Whitney Armstrong <warmstrong@anl.gov>
* Moved ATOF Track projections to ALERTEngine since it will need a track * Added many todo comments in code. * Cleaned up various if statements for clarity. * moved services to proper project directory structure that is picked up by javadocs --------- Co-authored-by: Whitney Armstrong <warmstrong@anl.gov>
* Moved ATOF Track projections to ALERTEngine since it will need a track * Added many todo comments in code. * Cleaned up various if statements for clarity. * moved services to proper project directory structure that is picked up by javadocs --------- Co-authored-by: Whitney Armstrong <warmstrong@anl.gov>
Uh oh!
There was an error while loading. Please reload this page.