Skip to content

Conversation

@whit2333
Copy link
Collaborator

@whit2333 whit2333 commented Apr 3, 2025

  • Moved ATOF Track projections to ALERTEngine since it will need a track
  • Added many todo comments in code.
  • Cleaned up various if statements for clarity.
  • moved services to proper project directory structure that is picked up by javadocs

Whitney Armstrong and others added 5 commits March 27, 2025 14:32
	modified:   ahdc/Cluster/ClusterFinder.java
	modified:   ahdc/Distance/Distance.java
	modified:   ahdc/HelixFit/HelixFitJava.java
	modified:   ahdc/HelixFit/HelixFitObject.java
	modified:   ahdc/PreCluster/PreCluster.java
	modified:   service/AHDCEngine.java
Whitney Armstrong added 5 commits April 3, 2025 14:31
	modified:   reconstruction/alert/src/main/java/org/jlab/rec/service/ALERTEngine.java
…ERTEngine.java

	modified:   reconstruction/alert/src/main/java/org/jlab/rec/service/ATOFEngine.java
@whit2333 whit2333 requested review from N-Plx and mathieuouillon and removed request for mathieuouillon April 4, 2025 19:11
@whit2333 whit2333 requested a review from baltzell April 4, 2025 19:17
@baltzell
Copy link
Collaborator

baltzell commented Apr 4, 2025

I suspect people might prefer to leave the old ones intact for now, maybe just suffix their names to designate they're the old ones.

@whit2333
Copy link
Collaborator Author

whit2333 commented Apr 5, 2025

I suspect people might prefer to leave the old ones intact for now, maybe just suffix their names to designate they're the old ones.

Not sure what you are saying? The old Engines are still there and used. The only change is I moved the Track projections into ALERTEngine where it is more appropriate.

@baltzell
Copy link
Collaborator

baltzell commented Apr 5, 2025

Yes, the old ones' names are still there and used, but their functionality is changed, and their previous functionality is no longer easily accessible. In the short term, it'd probably be better to keep their functionality easily accessible, and one easy way to do that is by renaming those old engine classes with a suffix, rather than replacing them, simultaneously designating that they'll be going away in the near future.

@whit2333
Copy link
Collaborator Author

whit2333 commented Apr 5, 2025

I still don't understand. All I have done is add a new engine called ALERTEngine. None of the functionality changed. I can move the projection back to ATOFEngine but the next PR will move it out of there....

	modified:   service/ALERTEngine.java
	modified:   service/ATOFEngine.java
baltzell
baltzell previously approved these changes Apr 6, 2025
Whitney Armstrong added 5 commits April 5, 2025 22:02
	modified:   ../../../../../../../../common-tools/clas-geometry/src/main/java/org/jlab/geom/base/Component.java
	renamed:    ../rec/service/AHDCEngine.java -> ahdc/AHDCEngine.java
	renamed:    ../rec/service/ALERTEngine.java -> alert/ALERTEngine.java
	renamed:    ../rec/service/ATOFEngine.java -> atof/ATOFEngine.java
@whit2333 whit2333 merged commit 77b67cd into development Apr 6, 2025
34 checks passed
@baltzell baltzell deleted the ALERT_Engine branch May 21, 2025 21:33
c-dilks pushed a commit that referenced this pull request Sep 15, 2025
*    Moved ATOF Track projections to ALERTEngine since it will need a track
*    Added many todo comments in code.
*    Cleaned up various if statements for clarity.
*    moved services to proper project directory structure that is picked up by javadocs


---------

Co-authored-by: Whitney Armstrong <warmstrong@anl.gov>
tongtongcao pushed a commit that referenced this pull request Sep 22, 2025
*    Moved ATOF Track projections to ALERTEngine since it will need a track
*    Added many todo comments in code.
*    Cleaned up various if statements for clarity.
*    moved services to proper project directory structure that is picked up by javadocs


---------

Co-authored-by: Whitney Armstrong <warmstrong@anl.gov>
tongtongcao pushed a commit that referenced this pull request Nov 18, 2025
*    Moved ATOF Track projections to ALERTEngine since it will need a track
*    Added many todo comments in code.
*    Cleaned up various if statements for clarity.
*    moved services to proper project directory structure that is picked up by javadocs


---------

Co-authored-by: Whitney Armstrong <warmstrong@anl.gov>
tongtongcao pushed a commit that referenced this pull request Nov 21, 2025
*    Moved ATOF Track projections to ALERTEngine since it will need a track
*    Added many todo comments in code.
*    Cleaned up various if statements for clarity.
*    moved services to proper project directory structure that is picked up by javadocs


---------

Co-authored-by: Whitney Armstrong <warmstrong@anl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants